Preventing image tagged "-dirty" from being deployed

[Brian Walter]

Hello, there!

My team has been very happy with skaffold and really appreciate all the work done on it!

Quick question...

When using skaffold, I understand that if the workspace has uncommitted changes, a -dirty suffix is appended to the image tag.

Is there anyway to prevent developers from deploying an image that is tagged "-dirty" explicitly via flag or config (.yaml)?

Example:

skaffold run -p production --do-not-allow-deploy-with-dirty-image=true

Thanks!

-Brian

[Brian de Alwis]

Hi Brian.

If you’re specifically concerned about the presence of “dirty” in the tag, then you could configure a different tagger.

But I think you’re really asking if you could prevent your developers from deploying workspaces with uncommitted changes.  We don’t have any way to enforce that at present, though you could accomplish this with our planned pre-deploy hooks (#1441).

Brian.

--
You received this message because you are subscribed to the Google Groups "skaffold-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skaffold-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/skaffold-users/58fe2a64-07cf-4af1-afa1-fbe586d8d782%40googlegroups.com.

[Brian Walter]

Ok, thank you Brian. I'll monitor that MR and we will use a workaround in the meantime.

Thanks, again!

-Brian

On Tuesday, June 2, 2020 at 4:09:45 PM UTC-5, Brian de Alwis wrote:

Hi Brian.

If you’re specifically concerned about the presence of “dirty” in the tag, then you could configure a different tagger.

But I think you’re really asking if you could prevent your developers from deploying workspaces with uncommitted changes.  We don’t have any way to enforce that at present, though you could accomplish this with our planned pre-deploy hooks (#1441).

Brian.

On Jun 2, 2020, at 12:55 PM, Brian Walter <bw....@gmail.com> wrote:

Hello, there!

My team has been very happy with skaffold and really appreciate all the work done on it!

Quick question...

When using skaffold, I understand that if the workspace has uncommitted changes, a -dirty suffix is appended to the image tag.

Is there anyway to prevent developers from deploying an image that is tagged "-dirty" explicitly via flag or config (.yaml)?

Example:

skaffold run -p production --do-not-allow-deploy-with-dirty-image=true

Thanks!

-Brian

--
You received this message because you are subscribed to the Google Groups "skaffold-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to skaffol...@googlegroups.com.