SiteMesh 3 breaks Struts 2 FileUploadInterceptor?

[xtian]

Since I upgraded from SiteMesh 2 to SiteMesh 3, my upload forms
stopped working.
Removing the SiteMesh filter brings them back to life, so there must
be a connection...

I'm using Struts2 FileUploadInterceptor. The interceptor is ignoring
my upload requests.
The relevant code is the following:

public String intercept(ActionInvocation invocation) throws
Exception {
ActionContext ac = invocation.getInvocationContext();
HttpServletRequest request = (HttpServletRequest)
ac.get(ServletActionContext.HTTP_REQUEST);
if (!(request instanceof MultiPartRequestWrapper)) {
if (LOG.isDebugEnabled()) {
LOG.debug(... very long debug message here ...)
}
return invocation.invoke();
}

When I click on my upload button, I get the debug message saying that
the action in bypassed.
That's because SiteMesh 3 is replacing the MultiPartRequestWrapper
with org.sitemesh.webapp.contentfilter.HttpServletRequestFilterable

Any way to fix this?
I tried with the Apache ActionContextCleanUp filter as suggested here
(http://osdir.com/ml/java.appfuse.user/2007-02/msg00096.html) but it
breaks everything.

[xtian]

P.S. I'm using sitemesh-3.0-alpha-1.zip

[Richard L. Burton III]

If you can send over a test case, I'll look into it what's going on.

--
-Richard L. Burton III

[xtian]

I wrote a small webapp. How do I send it over?

Apparently the behavior of struts with sitemesh 3 depends on the
invocation sequence of the filters.

This sequence works with sitemesh not with struts upload:

struts-prepare
sitemesh
struts-execute

This sequence works with struts upload, not with sitemesh:

sitemesh
struts-prepare
struts-execute

[Richard L. Burton III]

mrburton (at) gmail.com would work.

[xtian]

While I wait for an official fix, I patched the struts
FileUploadInterceptor with a dirty hack:

if (request instanceof
org.sitemesh.webapp.contentfilter.HttpServletRequestFilterable) {
request = (HttpServletRequest)
((org.sitemesh.webapp.contentfilter.HttpServletRequestFilterable)request).getRequest();
}

These lines must be added to
org.apache.struts2.interceptor.FileUploadInterceptor, in the "public
String intercept(ActionInvocation invocation)" method, just after
"HttpServletRequest request = ..."

To patch this class you just need to copy its source to your
application, keeping it in the original package.

[crashworx]

Hi,

did you ever find a solution to this ... i've got the same issue, using sitemesh 3 alpha 2..

[Subham Kumar Saha]

We had the same issue when we upgraded to sitemesh 3. File uploads were not working.

Below is a custom interceptor we used as a workaround.

public class SitemeshFileUploadInterceptor extends AbstractInterceptor {


  @Override

  public String intercept(ActionInvocation invocation) throws Exception {

    ActionContext actionContext = invocation.getInvocationContext();
    Object request = actionContext.get(ServletActionContext.HTTP_REQUEST);
    if (request instanceof HttpServletRequestFilterable) {
      ServletRequest wrappedRequest = ((HttpServletRequestWrapper) request).getRequest();
      if (wrappedRequest instanceof MultiPartRequestWrapper) {

        actionContext.put(ServletActionContext.HTTP_REQUEST, wrappedRequest);
      }
    }
    return invocation.invoke();
  }
}