[sirikata/sirikata] 4d1bb2: Multiple SST bug fixes and performance improvement...

[GitHub]

Branch: refs/heads/master
Home: https://github.com/sirikata/sirikata
Commit: 4d1bb2756e87b8b21f47e2ee0b7e468c660d6ffc
https://github.com/sirikata/sirikata/commit/4d1bb2756e87b8b21f47e2ee0b7e468c660d6ffc
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-04-11 (Thu, 11 Apr 2013)

Changed paths:
M libcore/include/sirikata/core/network/SSTImpl.hpp
M test/unit/libcore/MockSST.hpp
M test/unit/libcore/SSTTest.hpp

Log Message:
-----------
Multiple SST bug fixes and performance improvements.

* Fix connection sequence acks, where some packets would not be acked
properly and always cause apparent drops and immediate backoffs.
* Also fix handling of first connection packet, which was forced to
stay in the queued packets so it would be retransmitted if
necessary, but hadn't been removed upon successful connection. This
led to it being transmitted again and not acked.
* Properly handle reordering of initial connection sequence
packets. The previous assumption about proper ordering could cause
the loss of data as the first data packet would be processed first
and its data ignored.
* Add slow start support so we can increase the rate much more quickly
initially. This is a huge performance improvement and gets us to
pretty sane rates even when there is delay.
* Update SST tests to use larger medium sized payloads and make the
lossy channel due to congestion since consistent probabilistic
dropping is unrealistica and causes constant back off.


Commit: 02f630f1be16ca5cb26d19a5189a615ce2ed2f7e
https://github.com/sirikata/sirikata/commit/02f630f1be16ca5cb26d19a5189a615ce2ed2f7e
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-04-11 (Thu, 11 Apr 2013)

Changed paths:
M libspace/plugins/twitter/TwitterAggregateManager.cpp

Log Message:
-----------
Fix missing return.


Compare: https://github.com/sirikata/sirikata/compare/138d8c5f11d5...02f630f1be16