[sirikata/prox] f2ed87: Avoid a sqrt in satisfiesConstraintsBoundsAndMaxSi...

[GitHub]

Branch: refs/heads/master
Home: https://github.com/sirikata/prox
Commit: f2ed8700a5eb19f51e9a4ec48cac07beeed1d710
https://github.com/sirikata/prox/commit/f2ed8700a5eb19f51e9a4ec48cac07beeed1d710
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-02-27 (Wed, 27 Feb 2013)

Changed paths:
M libprox/include/prox/rtree/Constraints.hpp

Log Message:
-----------
Avoid a sqrt in satisfiesConstraintsBoundsAndMaxSize.


Commit: d4b08ede801dc942ec680f3bbf6a426406d639ff
https://github.com/sirikata/prox/commit/d4b08ede801dc942ec680f3bbf6a426406d639ff
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-02-28 (Thu, 28 Feb 2013)

Changed paths:
M libprox/include/prox/rtree/Constraints.hpp
M libprox/include/prox/util/SolidAngle.hpp
M libprox/src/SolidAngle.cpp

Log Message:
-----------
Further optimize query tests.

Require an additional method in SolidAngle that performs a cheaper but
equivalent comparison, allowing us to further reduce the cost of solid
angle query tests. However, there is still one sqrt that is required.


Commit: c377ab3a9992fb421bd93a6796eafd0ddd75a807
https://github.com/sirikata/prox/commit/c377ab3a9992fb421bd93a6796eafd0ddd75a807
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-02-28 (Thu, 28 Feb 2013)

Changed paths:
M libprox/include/prox/rtree/RTreeCore.hpp

Log Message:
-----------
Get rid of some duplicate computation in rtree data.

The data classes were just overriding values computed by the base
class, which led to extra unnecessary computation. Instead, expose a
simple constructor that requires the subclasses to compute the value
since it varies.


Commit: 60ea70f37018c3f816dfc0e5eba42c82d857563f
https://github.com/sirikata/prox/commit/60ea70f37018c3f816dfc0e5eba42c82d857563f
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-02-28 (Thu, 28 Feb 2013)

Changed paths:
M libprox/include/prox/geom/LevelQueryHandler.hpp
M libprox/include/prox/geom/RTreeCutQueryHandler.hpp

Log Message:
-----------
Replace direct manipulation of query results with method calls.

This will make it easier to refactor a bit of this code.


Commit: 773bdc038072b2fab60c2ab49e4e5aca88e6a5a9
https://github.com/sirikata/prox/commit/773bdc038072b2fab60c2ab49e4e5aca88e6a5a9
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-02-28 (Thu, 28 Feb 2013)

Changed paths:
M libprox/include/prox/geom/LevelQueryHandler.hpp
M libprox/include/prox/geom/RTreeCutQueryHandler.hpp
M libprox/include/prox/manual/RTreeManualQueryHandler.hpp
M libprox/include/prox/rtree/Cut.hpp
M libprox/include/prox/rtree/CutNode.hpp
M libprox/include/prox/util/ObjectID.hpp

Log Message:
-----------
Track whether cut nodes are in the result set.

Use a bit in the CutNode to track whether it's currently in the result
set. This makes checking membership for those nodes faster. However,
this is only a modest improvement for now because the leaf objects
still require lookups because we don't have enough space anywhere to
save whether they are in the results yet.


Commit: 09a191c474a3a7d3529574a1a376199974366423
https://github.com/sirikata/prox/commit/09a191c474a3a7d3529574a1a376199974366423
Author: Ewen Cheslack-Postava <ewe...@cs.stanford.edu>
Date: 2013-03-04 (Mon, 04 Mar 2013)

Changed paths:
M libprox/include/prox/geom/LevelQueryHandler.hpp
M libprox/include/prox/geom/RTreeCutQueryHandler.hpp
M libprox/include/prox/manual/RTreeManualQueryHandler.hpp
M libprox/include/prox/rtree/Cut.hpp

Log Message:
-----------
Use remove/tryRemove on cuts depending on situation.

Distinguish between remove, which should definitely have the object to
be removed in the result set, and tryRemove, which tests if it is
there, removes it if it is, and returns whether it was removed. This
fixes a crashing assert since in some cases we were asserting that the
object was in the results when we were only trying to remove it if it
was.


Compare: https://github.com/sirikata/prox/compare/0cfdc20e2952...09a191c474a3