[sipxtapi] r1424 committed - Applied patch from Saab:...

[codesite...@google.com]

Revision: 1424
Author: jaroslavl1
Date: Mon Feb 7 14:27:39 2011
Log: Applied patch from Saab:
- Fixed memory leak: In sendRequest line 269+ a copy is made of the
SipMessage. There is an interesting comment, but it looks a bit pointless
as the instance is thrown away without deleting it.
http://code.google.com/p/sipxtapi/source/detail?r=1424

Modified:
/trunk/sipXtackLib/src/net/SipRefreshMgr.cpp

=======================================
--- /trunk/sipXtackLib/src/net/SipRefreshMgr.cpp Sun Jan 24 03:43:15 2010
+++ /trunk/sipXtackLib/src/net/SipRefreshMgr.cpp Mon Feb 7 14:27:39 2011
@@ -266,6 +266,8 @@
// lease period timeout if the timer triggers and we've not received
// a good response from the server within FAILED_PERCENTAGE_TIMEOUT
// secs resubscribe
+ // LBA: Whats the point???:
+ /*
SipMessage* message = new SipMessage( request );

if (!message)
@@ -275,6 +277,7 @@
{
message->setResponseListenerData(
request.getResponseListenerData() );
}
+ */
}
else
{
@@ -625,11 +628,11 @@

if ( method.compareTo(SIP_REGISTER_METHOD) == 0 )
{
- //reschedule only if expires value != 0, otherwise it means we just
did an unregister
+ // Reschedule only if expires value != 0, otherwise it means we just
did an unregister
if ( requestRefreshPeriod == 0 )
{

- // if its an unregister, remove all related messasges
+ // if its an unregister, remove all related messages
// from the appropriate request list
response->setCSeqField(-1, method);
// TODO - should also destroy the timer now