sip.js & ICE trickle

557 views
Skip to first unread message

Mark Diaz

unread,
May 31, 2019, 6:14:20 PM5/31/19
to SIP.js
Hi!

      I have a Session Description Handler built and would like to know the recommended method of handling ICE trickle from clients within sip.js?

Mark Diaz

unread,
Jun 5, 2019, 9:06:52 AM6/5/19
to SIP.js
So perhaps I wasn't explaining properly. A client connected to sip,js sending ICE trickle. Would the best way to wait to collect all the candidates before creating the new session? Or once the session is created can I add the new candidate(s) to the session somehow?

James Criscuolo

unread,
Jun 5, 2019, 9:46:48 AM6/5/19
to SIP.js
Sorry, i meant to answer this yesterday. Based on this article it looks like there is a way to implement it, but it is not perfect, and forking would also likely be a nightmare. We don't currently support what is listed there, but would be open to a pull request. Based on your specific case, it looks like the initial caller can not trickle ice for the offer, only the answer and subsequent re-invites, once support has been confirmed. Currently, all candidates are collected, then sent with the SDP in the offer (invite w/o SDP the ice collection will occur for the answer).

Mark Diaz

unread,
Jun 5, 2019, 10:29:11 AM6/5/19
to SIP.js
I see. We also came to the conclusion to simply give a short time to gather candidates before initiating the session. I suppose in my brain I was thinking this was kinda "hacky" and there might be more optimized method but apparently not :) I'm probably over complicating it. I'll certainly play with it tho and if we come up with another method we believe could benefit we will absolutely submit a PR :) Thanks James!
Reply all
Reply to author
Forward
0 new messages