[Bug 436673] [NEW] css code added in the stylesheet field is not rendered

[mirella]

Public bug reported:

I'm using version 0.8.10.
When I add css in the css stylesheet field in portal_newsletters/channels/default-channel (tab composer), the css is not rendered.
I looked at the composer-html.pt in browser directory of singing and dancing and I saw that the stylesheet tag was closed like this:
<style type="text/css"
tal:content="structure options/stylesheet"/>

some html tags needs the </tag> closing to work properly. For the style-tag is the case:
<style type="text/css"
tal:content="structure options/stylesheet"></style>

When I do this, then the css does work.

** Affects: singing-dancing
Importance: Undecided
Status: New

--
css code added in the stylesheet field is not rendered
https://bugs.launchpad.net/bugs/436673
You received this bug notification because you are a member of Singing &
Dancing developers, which is the registrant for Singing & Dancing.

Status in Singing & Dancing: New

Bug description:
I'm using version 0.8.10.
When I add css in the css stylesheet field in portal_newsletters/channels/default-channel (tab composer), the css is not rendered.
I looked at the composer-html.pt in browser directory of singing and dancing and I saw that the stylesheet tag was closed like this:
<style type="text/css"
tal:content="structure options/stylesheet"/>

some html tags needs the </tag> closing to work properly. For the style-tag is the case:
<style type="text/css"
tal:content="structure options/stylesheet"></style>

When I do this, then the css does work.

[Daniel Nouri]

Please go ahead and make the required change in SVN.

[Daniel Widerin]

imo this change is not necessary, because "tal:content" does close the
tag itself.

[mirella]

You're right about that. But what I experience is the following: when I
add the css in the css-field. (with my fix). The css is not placed in
<style>...</style> tag. But in <h2 style="font-size:14px">. I'm new to
singing and dancing, so I think there is a reason for generating the
style attribute instead of adding it in <style>..</style>?

[Daniel Widerin]

stoneagehtml.compactify(html) does analyse the css definitions in style
tags and assign it to each html-element directly. this makes the
rendered mail look like it should in almost any mail client.

[tmog]

As stated, css is always rendered inline using stoneagehtml. This did
strip out some definitions that mail-clients typically do not
understand. This was changed in r99562 so definitions are no longer
stripped.

Closing this as fixed.

** Changed in: singing-dancing
Status: New => Won't Fix

** Changed in: singing-dancing
Status: Won't Fix => Fix Committed

** Changed in: singing-dancing
Status: Fix Committed => Fix Released

--
css code added in the stylesheet field is not rendered
https://bugs.launchpad.net/bugs/436673
You received this bug notification because you are a member of Singing &
Dancing developers, which is the registrant for Singing & Dancing.

Status in Singing & Dancing: Fix Released