Re: please ... stop monkey patch

[Daniel Nouri]

Hello Jean-Michel!

Let me CC the list on this one.

On Mon, Nov 16, 2009 at 9:32 AM, toutpt
<jeanmiche...@makina-corpus.com> wrote:
> Sure, the patch is always in dancing. I would be glade if you upstream it to
> ATContentTypes or release it under an other packages. My bugs has not been
> fixed yet https://dev.plone.org/plone/ticket/9591

Okay, so that still needs to land upstream. It's a clear case. Maybe
you can find some time to do this? (Youshould have/get Collective
access!)

> I don't know what is the best way in that case. collective.singing and dancing
> are both great and full features, but theire are so many monkey patches
> inside.
>
> For example why not doing a five.appcatalog to replace this:
> http://svn.plone.org/svn/collective/collective.singing/trunk/collective/singing/patch/

When I started S&D, one goal was for the core parts (singing) to be
functional without Zope 2. Maybe we could still improve the situation
by doing conditional imports or so. Have you had problems with that
particular zope.app.catalog patch in the past? If so, we should
probably look into it.

> You also can put a log and/or use collective.monkeypatcher for this.

+1. A log seems like a good idea.

> I have not doing anything at the moment for s&d. I want to have some words
> with you to know you point of view about this (monkey patches).
>
> I think we have to:
>
> * remove the patch on attopic and make it upstream

+1

> * remove the path to import zope.app.catalog in zope2 and make it
> five.appcatalog

+0. See above.

Regards,
Daniel

[jmf]

Hello Daniel,

> Okay, so that still needs to land upstream. It's a clear case. Maybe
> you can find some time to do this? (Youshould have/get Collective
> access!)

So I will care about this.

> When I started S&D, one goal was for the core parts (singing) to be
> functional without Zope 2.

Is it the case ?

>Have you had problems with that
> particular zope.app.catalog patch in the past?

Not really but I don't understand one line of the patch, and that made me
unconfortable with it. This is zope code and i had never read a line on btree.

>
> > You also can put a log and/or use collective.monkeypatcher for this.
>
> +1. A log seems like a good idea.

So I care also about the log.

Thank you very much.

--
Cordialement,
JeanMichel FRANCOIS
Makina-Corpus

[Daniel Nouri]

Jean-Michel,

On Tue, Nov 17, 2009 at 10:50 AM, jmf
<jeanmiche...@makina-corpus.com> wrote:
>> When I started S&D, one goal was for the core parts (singing) to be
>> functional without Zope 2.
>
> Is it the case ?

There seems to be an unnecesary dependency to plone.z3cform. Apart
from that, I don't think there's a problem with using it outside of
Zope 2. (Which I have never done.)

Thanks for your work on these issues!
Daniel