Re: [simpleinvoices] Invoice created with cron doesn't increment correctly (#111)

[Ap.Muthu]

Working on some sql fixes for domain_id issues with cron.

Currently it will work for domain_id=1 only as it is hardcoded.

Too much legacy code in sql_queries.php.

Which is the preferred method:

db->Query()

or

dbQuery()

?

 

 

----- Original Message -----

From: Justin Kelly

To: simpleinvoices/simpleinvoices

Sent: Thursday, October 24, 2013 9:42 AM

Subject: [simpleinvoices] Invoice created with cron doesn't increment correctly (#111)

https://plus.google.com/103209381350517028112/posts/2sebKsPcFYX

—
Reply to this email directly or view it on GitHub.

[Justin Kelly]

thanks ap - assuming they are the same jsut use db->Query where possible

we'll try and move everything out of sql_queries.php

[Ap.Muthu]

Actually the alternative is better - dbQuery() standalone function. It does not have the need to declare the global $db and all such abstraction can be done inside of the dbQuery() function in just one place.

 

----- Original Message -----

From: Justin Kelly

To: Ap.Muthu

Cc: SI Group

Sent: Monday, October 28, 2013 6:03 AM

Subject: Re: [simpleinvoices] Invoice created with cron doesn't increment correctly (#111)

thanks ap - assuming they are the same jsut use db->Query where possible

we'll try and move everything out of sql_queries.php

[Justin Kelly]

thanks ap - my preference is is to use class and remove everythign from sql_queries.php