db querying functions in functions.php - why?

12 views
Skip to first unread message

Ap.Muthu

unread,
Oct 26, 2013, 4:49:53 PM10/26/13
to Justin James Kelly, SI Group
Why does the file functions.php contain database querying functions that
ought to be in sql_queries.php ?
The following functions are in question:

get_custom_field_label()
calc_invoice_paid()
calc_customer_total()
calc_customer_paid()
calc_invoice_tax()
show_custom_field()

Regards,
Ap.Muthu

Justin Kelly

unread,
Oct 27, 2013, 8:30:34 PM10/27/13
to Ap.Muthu, SI Group
just legacy code - can be moved in sql_queries or appropriate classes

Ap.Muthu

unread,
Oct 28, 2013, 12:24:01 AM10/28/13
to Justin Kelly, SI Group
Just wondering if they had any significance in their order of getting loaded into index.php aka early_exit!
 
----- Original Message -----
From: Justin Kelly
To: Ap.Muthu
Sent: Monday, October 28, 2013 6:00 AM
Subject: Re: db querying functions in functions.php - why?

just legacy code - can be moved in sql_queries or appropriate classes

Justin Kelly

unread,
Oct 28, 2013, 12:29:21 AM10/28/13
to Ap.Muthu, SI Group
is possible - thats what i was thinking but should be fine to remove it

Ap.Muthu

unread,
Oct 28, 2013, 2:31:34 AM10/28/13
to Justin Kelly, SI Group
----- Original Message -----
From: Justin Kelly
Sent: Monday, October 28, 2013 6:00 AM
Subject: Re: db querying functions in functions.php - why?

just legacy code - can be moved in sql_queries or appropriate classes

Justin Kelly

unread,
Oct 28, 2013, 6:56:31 AM10/28/13
to Ap. Muthu, SI Group

Thanks, next to start moving everything out of sql_queries into class files

Reply all
Reply to author
Forward
0 new messages