sort_merge_arrays ---> sort_merged_arrays

[David Cooke]

I started getting these errors:
[root@kuat ~]# puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, The merge options has wrong type, unrecognized key 'sort_merge_arrays' at /etc/puppetlabs/code/environments/production/manifests/site.pp:43:1 on node kuat.ndc.nasa.gov
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run


It seems to have started when puppet-agent updated to from 1.8.3-1 to 1.10.6-1.

I downgraded puppet-agent to 1.8.3-1 and, of course, it ran and updated back to 1.10.6-1.  Hilarious, I know, but it does confirm that that is when the problem started.

The only place I find the string "sort_merge_arrays" is in /etc/puppetlabs/code/environments/simp/modules/simp/data/common.yaml:
[root@server production]# grep -R sort_merge_arrays *      
modules/simp/data/common.yaml:      sort_merge_arrays: true
modules/simp/data/common.yaml:      sort_merge_arrays: true
modules/simp/data/common.yaml:      sort_merge_arrays: true

After some googling where I found some mentions of changing "sort_merge_arrays" to "sort_merged_arrays", I tried it and got puppet working again.

I'm not sure exactly what's going on here or what the real solution is but thought this should be reported.

[Dylan Cochran]

Unfortunately, the way Puppet instituted this change made it difficult to handle in modules that used that feature at all. A fix has already been added to SIMP 6.1 to resolve the problem by not sorting the arrays at all, which works on all puppet versions. Nothing in SIMP requires those classes to be included in order.