Issue 428 in simile-widgets: Lenses uses "className" for all IE - but that does not work anymore in IE8 (needs "class")

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 428 by walter.j...@gmail.com: Lenses uses "className" for all IE
- but that does not work anymore in IE8 (needs "class")
http://code.google.com/p/simile-widgets/issues/detail?id=428

What steps will reproduce the problem?
1. make lens templates with class attributes for styling
2. try it in IE7 and IE8

What is the expected output? What do you see instead?
in both IE's "className" attribute is used (instead of "class") - that is
needed to make it work in IE7 but in IE8. Code that needs to be changed is
in lens.js around line 480.

What version of the product are you using? On what browser and what
operating system?
SIMILE Exhibit 2.2

[codesite...@google.com]

Comment #1 on issue 428 by emily.br...@duke.edu: Lenses uses "className"

for all IE - but that does not work anymore in IE8 (needs "class")
http://code.google.com/p/simile-widgets/issues/detail?id=428

Hi, just wondering if anybody knows when this bug might be fixed or if
there is a workaround? Thanks!

[David Karger]

If we change className to class, will it stop working on IE7?
Will putting in both class and className produce problems in either
version of IE?

[David Karger]

I've checked in a fix at trunk.simile-widgets.org . Please confirm that
it works.

On 5/2/2011 8:40 AM, codesite...@google.com wrote:
>

[codesite...@google.com]

Comment #4 on issue 428 by rajeevka...@gmail.com: Lenses uses "className"

for all IE - but that does not work anymore in IE8 (needs "class")
http://code.google.com/p/simile-widgets/issues/detail?id=428

in lens.js, line#418 change from

name = "className";

to

name = "class";

Then the classes come correctly in IE8+.

[codesite...@google.com]

Comment #5 on issue 428 by rajeevka...@gmail.com: Lenses uses "className"

for all IE - but that does not work anymore in IE8 (needs "class")
http://code.google.com/p/simile-widgets/issues/detail?id=428

After making the change, you can recreate the budle or edit the
exhibit-bundle.js (2.2.0) and make same change on line#4375.

I hope this helps someone struggling on IE8, IE9 to make the lens format
work correctly.

[David Karger]

Did you check whether this problem holds in trunk? Try
http://trunk.simile-widgets.org/exhibit/api . I think I fixed it there.