Issue 391 in simal: Add classes to HTML elements to improve stylability
si...@googlecode.com
Owner: ----
Labels: Type-Defect
New issue 391 by Stev...@gmail.com: Add classes to HTML elements to improve
stylability
http://code.google.com/p/simal/issues/detail?id=391
The attached is all the changes I've made so far in adding CSS classes to
HTML elements. It's not really tidy or complete, but I'd like to get some
of these checked in to avoid getting ambushed by more changes in the
repository.
Some of these classes are set by code in Java, whereas they could and
should be set statically in the HTML. Oops.
Attachments:
webdiff.txt 39.3 KB
si...@googlecode.com
Labels: -Type-Defect Type-Enhancement Priority-Low Maintainability
Component-Webapp
Comment #1 on issue 391 by ross.gardler: Add classes to HTML elements to
improve stylability
http://code.google.com/p/simal/issues/detail?id=391
There are a number of problems with this patch. The first is, as you
observe, quite a few HTML clases are set in the java rather than the HTML.
This is bad practice and difficult to maintain. There are one or two placed
where the class is changed depending on the number of rows - naturally this
is necessary in the java code.
There are also some very large changes to files that appear to be white
space only, but the number of changes makes it very difficult to review
those files before committing.
Please resubmit with these two issues addressed and we'll apply immediately.
In general it is best to submit small cange sets as it makes reviewing much
easier. Each change should address a single issue (i.e. style the x section
of the edit page)
si...@googlecode.com
Comment #2 on issue 391 by Stev...@gmail.com: Add classes to HTML elements
http://code.google.com/p/simal/issues/detail?id=391
Ok, I've had a closer look at Eclipes's SVN integration - looks like I
vastly underestimated it.
The attached diff just covers classes in html files. Looks like the noise
in PersonBrowserPage.html was due to line endings.
Attachments:
classes.txt 10.5 KB
si...@googlecode.com
Comment #3 on issue 391 by Stev...@gmail.com: Add classes to HTML elements
http://code.google.com/p/simal/issues/detail?id=391
This one converts some div's to h3's. Sorry for the whitespace stuff in
projectlistpanel. I tried. I really did. But the file is half-Windows,
half-Unix. And Subclipse just refuses to ignore whitespace changes when
generating diffs.
Attachments:
divh3.txt 6.3 KB
si...@googlecode.com
Comment #4 on issue 391 by Stev...@gmail.com: Add classes to HTML elements
http://code.google.com/p/simal/issues/detail?id=391
This one adds classes to elements in EditProjectPanel.html (rather than
using AttributeAppender).
Attachments:
EditProjectPanelhtml.txt 5.7 KB
si...@googlecode.com
Labels: -Type-Enhancement -Priority-Low Type-Patch Priority-Medium
Comment #5 on issue 391 by ross.gardler: Add classes to HTML elements to
improve stylability
http://code.google.com/p/simal/issues/detail?id=391
(No comment was entered for this change.)