successfullyinstalled always accessible

[Jean-Fabien Barrois]

I have noticed that the action successfullyinstalled is always available, on any controller.
ie http://ss3.demo.silverstripe.org/about/successfullyinstalled

This action is defined on ContentController. Maybe it is not the best approach, and this action should become unavailable once one has deleted the install files?
This doesn't reveal any username or password (unless one had a caching proxy when installing eventually) but it rebuilds the static 404 page. And, well, it shouldn't be available after a successful install IMHO :-)

I'm happy to come with a fix, but I'm happy to collect thoughts on how to do that too?

[UndefinedOffset]

You should probably submit a bug on open.silverstripe.org against 3.0.5. I think your right though, it really shouldn't exist or work post-install.

[Jean-Fabien Barrois]

Following UndefinedOffest's suggestion, I opened a ticket for this issue, which has been closed, as it is not a bug, and it's fair enough (I don't think it is a bug either).
The crowd is not going particularly wild on that topic, but the thread remains open for any suggestion on how to tackle this :-)

Greetings from Napier

[Nicolaas Thiemen Francken - Sunny Side Up]

Even if it is not a bug it can still become a ticket.  Maybe not for 3.0, but for future versions of SS. It is an enhancement that I am sure everyone agrees is a nice improvement. 

It seems to me that the action should be removed from Content Controller and moved to its own temporary controller. 

--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to silverstripe-d...@googlegroups.com.
To post to this group, send email to silverst...@googlegroups.com.
Visit this group at http://groups.google.com/group/silverstripe-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Nicolaas Thiemen Francken  

Sunny Side Up Ltd  {
  Skype: atyourservicehour
  Phone: +64 4 889 2773 

  Emergencies: 0221697577
  n...@sunnysideup.co.nz
  http://www.sunnysideup.co.nz

}

[Nicolaas Thiemen Francken - Sunny Side Up]

alternatively, after installation, the method could show different information (e.g. the website credits). 

[Ingo Schommer]

Hey Nicolaas,

On 4/04/2013, at 9:45 PM, Nicolaas Thiemen Francken 

Even if it is not a bug it can still become a ticket.  Maybe not for 3.0, but for future versions of SS. It is an enhancement that I am sure everyone agrees is a nice improvement. 

I know we handled those "wouldn't it be nice if …" tickets like that previously,
but I'm going to be advocating a more pragmatic approach going forward.

"Everyone agrees its a nice improvement" is no longer enough to get into the bugtracker.
If everyone *does* agree, surely somebody will find it important enough to submit a pull request ;)

Basically, the bugtracker is for bugs, and enhancements which have an owner
who ensures they're actioned within a few weeks.

Ingo

[Fred Condo]

Done. Please see https://github.com/silverstripe/silverstripe-cms/pull/700

[Damian Mooyman]

Does /home/successfullyinstalled crash anyone's web server or is it just me?

My wamp seems to crash on the super-long translation string in the template. Can't figure out why. =( It works if I shorten it though.