Upgrading war stories

103 views
Skip to first unread message

Sam Minnée

unread,
Mar 13, 2012, 12:32:07 AM3/13/12
to SS Dev
Hi everyone,

Now that beta1 is out, we'd like to get people on this list to try upgrading their sites (e.g. in a test environment) and report back on how it goes.

- Was it successful?
- Are the upgrade notes complete?
- What has tripped you up or confused you?

Look forward to hearing your feedback!

Thanks,
Sam

Nick

unread,
Mar 22, 2012, 9:00:36 AM3/22/12
to SilverStripe Core Development
Hi there,

I've got a large Silverstripe site which I am attempting to upgrade.

I'm trying to work through some issues.

I had a problem with the install changing a MyISAM page type table to
INNODB (row too large!).

Plenty of deprecated messages (which I can't quite locate the source
of these method calls):
Deprecation::notice(3.1.0,combined_static is deprecated, replaced
by Config#get)
Object.php:332
Object::get_static(AssetAdmin,url_base)
CMSMenu.php:84
CMSMenu::add_director_rule_for_controller(AssetAdmin)
array_map(Array,Array)
CMSMenu.php:41
CMSMenu::add_director_rules()
_config.php:10
require_once(/Applications/MAMP/htdocs/SilverStripe3b1/sapphire/
admin/_config.php)
_config.php:86
require_once(/Applications/MAMP/htdocs/SilverStripe3b1/sapphire/
_config.php)
ConfigManifest.php:88
SS_ConfigManifest->activateConfig()
Config.php:171
Config->pushConfigManifest(SS_ConfigManifest)
Core.php:263
require_once(/Applications/MAMP/htdocs/SilverStripe3b1/sapphire/
core/Core.php)
main.php:61




Some issues with the new ORM I would guess...

[Notice] Undefined variable: text
GET /SilverStripe3b1/

Line 733 in /Applications/MAMP/htdocs/SilverStripe3b1/sapphire/model/
Database.php
Source

724 * Convert a SQLQuery object into a SQL statement
725 */
726 public function sqlQueryToString(SQLQuery $sqlQuery) {
727 $distinct = $sqlQuery->distinct ? "DISTINCT " : "";
728 if($sqlQuery->delete) {
729 $text = "DELETE ";
730 } else if($sqlQuery->select) {
731 $text = "SELECT $distinct" . implode(", ", $sqlQuery->select);
732 }
733 if($sqlQuery->from) $text .= " FROM " . implode(" ", $sqlQuery-
>from);
734 if($sqlQuery->where) $text .= " WHERE (" . $sqlQuery-
>getFilter(). ")";
735 if($sqlQuery->groupby) $text .= " GROUP BY " . implode(", ",
$sqlQuery->groupby);
736 if($sqlQuery->having) $text .= " HAVING ( " . implode(" ) AND
( ", $sqlQuery->having) . " )";
737 if($sqlQuery->orderby) $text .= " ORDER BY " . $sqlQuery-
>orderby;
738
739 if($sqlQuery->limit) {

xeraa

unread,
Mar 22, 2012, 9:15:09 PM3/22/12
to silverst...@googlegroups.com
Something that is bugging me are the missing iterator specific methods in the template: http://doc.silverstripe.org/sapphire/en/trunk/reference/templates-upgrading-guide#iterator-specific
I've used them quite extensively in some projects. While I can replace most of the styling things with plain CSS, what's the replacement for more complex things (add markup depending on the position,...)?

Simon J Welsh

unread,
Mar 22, 2012, 9:17:43 PM3/22/12
to silverst...@googlegroups.com
Those have been removed from ViewableData and moved into TemplateIteratorProvider. This means they can still be used fine in your template, but not in PHP.

> --
> You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
> To view this discussion on the web visit https://groups.google.com/d/msg/silverstripe-dev/-/Ic8kePBrEpEJ.
> To post to this group, send email to silverst...@googlegroups.com.
> To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/silverstripe-dev?hl=en.
>

---
Simon Welsh
Admin of http://simon.geek.nz/

Sam Minnée

unread,
Mar 22, 2012, 9:35:04 PM3/22/12
to silverst...@googlegroups.com
Can you give us some examples of things you've done where this is causing problems?  As Simon said, you can still use them in templates, not PHP code, so we'd be keen to see examples of how you've used them in PHP code.

On 23/03/2012, at 2:15 PM, xeraa wrote:

xeraa

unread,
Mar 22, 2012, 9:53:24 PM3/22/12
to silverst...@googlegroups.com
My bad, I've totally overlooked that paragraph while going through the upgrading docs. I'm only using those in the template...

So I guess I can start upgrading then as Uncle Cheese has started to provide a wrapper for the DOM module :-).


Am Freitag, 23. März 2012 02:35:04 UTC+1 schrieb Sam Minnée:
Can you give us some examples of things you've done where this is causing problems?  As Simon said, you can still use them in templates, not PHP code, so we'd be keen to see examples of how you've used them in PHP code.

On 23/03/2012, at 2:15 PM, xeraa wrote:

Something that is bugging me are the missing iterator specific methods in the template: http://doc.​silverstripe.org/sapphire/en/​trunk/reference/templates-​upgrading-guide#iterator-​specific
I've used them quite extensively in some projects. While I can replace most of the styling things with plain CSS, what's the replacement for more complex things (add markup depending on the position,...)?

Am Dienstag, 13. März 2012 05:32:07 UTC+1 schrieb Sam Minnée:
Hi everyone,

Now that beta1 is out, we'd like to get people on this list to try upgrading their sites (e.g. in a test environment) and report back on how it goes.

 - Was it successful?
 - Are the upgrade notes complete?
 - What has tripped you up or confused you?

Look forward to hearing your feedback!

Thanks,
Sam





--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To view this discussion on the web visit https://groups.google.com/d/​msg/silverstripe-dev/-/​Ic8kePBrEpEJ.
To post to this group, send email to silverstripe-dev@googlegroups.​com.
To unsubscribe from this group, send email to silverstripe-dev+unsubscribe@​googlegroups.com.
To post to this group, send email to silverstripe-dev@googlegroups.​com.
To unsubscribe from this group, send email to silverstripe-dev+unsubscribe@​googlegroups.com.

Shelly Grist

unread,
Apr 8, 2012, 3:32:37 AM4/8/12
to silverst...@googlegroups.com
Hi Sam

I'm starting to convert my 2.4.7 C3:Commons project to the beta.  I've started with a clean install - which worked fine.  And then the plan was to slowly add each module written by others before I added my own code.  I've started with the memberprofiles and orderable modules and clearly there is a problem when I do the dev/build all it does is send me to a Security/login page.  It hasn't added any tables to the database.  Do I need to change some settings to see error codes in SS3 during dev/build?

Thanks, Shelly
Reply all
Reply to author
Forward
0 new messages