I've been tidying up some if the bootstrap code in main.php, and I
want to propose that we remove the ?debug_profile=1 feature.
In particular, I would advocate that anyone wanting to profile their
SilverStripe site uses Webgrind, which is a **much** better profiler.
It does mean that you have to install xdebug on your development box,
but this seems like a reasonable expectation.
What do people think? Is there a good reason to keep ?debug_profile=1
active in the system?
+1 internet for removing it!
--
You received this message because you are subscribed to the Google Groups "SilverStripe Development" group.
To post to this group, send email to silverst...@googlegroups.com.
To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/silverstripe-dev?hl=en.
+1 with a replacement strategy
-1 without one
On Jan 28, 5:30 am, Tim Klein <t...@kelpdesign.com> wrote:
> quick and simple way of checking why things are slow. especially when you
> cant set up xdebug on your host...
>
> i'd keep it
>
> -1
>
>
>
> On Thu, Jan 28, 2010 at 9:31 PM, stojg <stojg.lindqv...@gmail.com> wrote:
> > No, I think as you said that using xdebug profiling tools are a more
> > viable option than using the ?debug_profile=1.
>
> > +1 internet for removing it!
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "SilverStripe Development" group.
> > To post to this group, send email to silverst...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > silverstripe-d...@googlegroups.com<silverstripe-dev%2Bunsu...@googlegroups.com>
> To post to this group, send email to silverstripe-
> d...@googlegroups.com.
> To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com
I've used debug_profile to optimize big queries and find bottlenecks
in live systems a few times and it was a life-saver. From a core POV I
can see webgrind being essential, but for developers debugging/
optimization debug_profile works just fine.
Regards
Hamish
> >>> silverstripe-d...@googlegroups.com<silverstripe-dev%2Bunsubscrib e...@googlegroups.com
--
You received this message because you are subscribed to the Google Groups "SilverStripe Development" group.
To post to this group, send email to silverst...@googlegroups.com.
To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com.
On Jan 30, 3:13 am, Bjorn Radon <bjorn.ra...@gmail.com> wrote:
> Hi, I'm definitely for removing ?debug_profile, in fact I'm in favour in
> removing most $_GET - solutions that end up cluttering the source code.
> debug_memory could go as well imho. As far as I can see it is accessible on
> all SilverStripe sites, if it is not explicitly checked for in the .htaccess
> file. I don't like features that helps people determine what platform I am
> running my sites on, it opens them up for targeted attacks...
> I found a horrible exploit which was fixed in the 2.3.5 release, based on a
> query parameter, so I am in favour of removing as many as possible.
>
> Maybe an observable/observer pattern can be applied in the core classes?
> With some standard observers (with text or html file output) that can be
> enabled by the site config or similar the need for easy debugging could be
> met. Maybe this is coming up with the logging functionality in trunk
>
> Björn Radon
>
> 2010/1/28 Sam Minnee <sam.min...@gmail.com>
>
>
>
> > Hi everyone,
>
> > I've been tidying up some if the bootstrap code in main.php, and I
> > want to propose that we remove the ?debug_profile=1 feature.
>
> > In particular, I would advocate that anyone wanting to profile their
> > SilverStripe site uses Webgrind, which is a **much** better profiler.
> > It does mean that you have to install xdebug on your development box,
> > but this seems like a reasonable expectation.
>
> > What do people think? Is there a good reason to keep ?debug_profile=1
> > active in the system?
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "SilverStripe Development" group.
> > To post to this group, send email to silverst...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > silverstripe-d...@googlegroups.com<silverstripe-dev%2Bunsubscrib e...@googlegroups.com>
+1 for getting rid of debug_profile and debug_memory
- Andrew
On Jan 29, 3:13 pm, Bjorn Radon <bjorn.ra...@gmail.com> wrote:
> Hi, I'm definitely for removing ?debug_profile, in fact I'm in favour in
> removing most $_GET - solutions that end up cluttering the source code.
> debug_memory could go as well imho. As far as I can see it is accessible on
> all SilverStripe sites, if it is not explicitly checked for in the .htaccess
> file. I don't like features that helps people determine what platform I am
> running my sites on, it opens them up for targeted attacks...
> I found a horrible exploit which was fixed in the 2.3.5 release, based on a
> query parameter, so I am in favour of removing as many as possible.
>
> Maybe an observable/observer pattern can be applied in the core classes?
> With some standard observers (with text or html file output) that can be
> enabled by the site config or similar the need for easy debugging could be
> met. Maybe this is coming up with the logging functionality in trunk
>
> Björn Radon
>
> 2010/1/28 Sam Minnee <sam.min...@gmail.com>
>
> > Hi everyone,
>
> > I've been tidying up some if the bootstrap code in main.php, and I
> > want to propose that we remove the ?debug_profile=1 feature.
>
> > In particular, I would advocate that anyone wanting to profile their
> > SilverStripe site uses Webgrind, which is a **much** better profiler.
> > It does mean that you have to install xdebug on your development box,
> > but this seems like a reasonable expectation.
>
> > What do people think? Is there a good reason to keep ?debug_profile=1
> > active in the system?
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "SilverStripe Development" group.
> > To post to this group, send email to silverst...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > silverstripe-d...@googlegroups.com<silverstripe-dev%2Bunsu...@googlegroups.com>
http://open.silverstripe.org/changeset/80057
http://open.silverstripe.org/changeset/74067
So, just got to wait a little longer.
> > > silverstripe-d...@googlegroups.com<silverstripe-dev%2Bunsubscrib e...@googlegroups.com>
> To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/silverstripe-dev?hl=en.
>
>
-------
Ingo Schommer | Senior Developer
SilverStripe
http://silverstripe.com
Phone: +64 4 978 7330 ext 42
Skype: chillu23
How about we only allow the use of debug_profile if an
SS_ALLOW_DEBUG_PROFILE define is set, and $_GET['debug_profile'] is
set?