Using docker to launch tomcat from offline mode development

[Olivier Sarrat]

Hi everyone,

AtolCD has just provided a great pull request fixing the offline mode for version 2.2.

In order to ease the offline mode development, they has extended what you can do with docker: once their pull request will be merged, you'll be able to launch tomcat from the command line.
More information here : https://github.com/sigmah-dev/sigmah/pull/101/commits/7c3e7f5f1c7e60eae7a12d5b02b4cc855550284c

What do you think about it ?

Best,

Olivier.

--

Olivier Sarrat
Ingénieur Systèmes d'Information / Information System Engineer

>>Sigmah (Twitter, Facebook, Linkedin, Google+)
Animateur du projet / project facilitator

>>Groupe URD (Twitter, Facebook)
La Fontaine des Marins
26170 Plaisians
Tel: + 33(0)4 75 28 29 35

Mobile: +33 (0)6.34.31.42.07    -    Skype: osarrat.urd

Par respect pour l'environnement,

n'imprimez ce mail qu'en cas d'absolue nécessité

 

[Thomas Broyer]

Le lundi 26 juin 2017 16:15:45 UTC+2, osarrat.urd a écrit :

Hi everyone,

AtolCD has just provided a great pull request fixing the offline mode for version 2.2.

In order to ease the offline mode development, they has extended what you can do with docker: once their pull request will be merged, you'll be able to launch tomcat from the command line.
More information here : https://github.com/sigmah-dev/sigmah/pull/101/commits/7c3e7f5f1c7e60eae7a12d5b02b4cc855550284c

What do you think about it ?

Hi, I'm about to revert that commit (and update the PR, as it actually introduces breakage), and possibly add a docker-tomcat.sh script with an (almost) equivalent "docker run".

The problem I have with this commit is that a basic "docker-compose up -d" that you'd use to launch your service requirements/dependencies for development will also download and launch the tomcat container.

This lead me to a related question: 18 months ago, there was a commit adding tomcat7-maven-plugin to the POM [1], which was reverted 9 days later with the reason that "tomcat 8 is required".

I don't get where that requirement comes from?

• there's (apparently) absolutely nothing specific to Tomcat in the application (sure the logback configuration depends on a catalina.base system property, but it works OK without it, just creates a catalina.base_IS_UNDEFINED folder at the root of the project instead, which is in the .gitignore for a while BTW [3]
• we at AtolCD primarily use "mvn gwt:run" for development, which uses Jetty 6
• the tomcat7-maven-plugin appears to work OK, despite the wiki [4] saying that “Sigmah won't work in Tomcat 7.”
• I've been trying the jetty-maven-plugin (in version 9.4), and it works well too (from what I've seen)

So I'm wondering: would you be opposed to either reintroducing the tomcat7-maven-plugin, and/or the jetty-maven-plugin? If some specific feature does actually only work in Tomcat 8, then I'd rather have it said explicitly somewhere, so I know I can use Tomcat 7 or Jetty for development as long as I don't need that feature.

[1] https://github.com/sigmah-dev/sigmah/commit/9cb3465cc69c1397ae8bd8b7ac044f4a07fa5867

[2] https://github.com/sigmah-dev/sigmah/commit/9f7eeac3db6837ca41c2eb4122bce6684669e668

[3] https://github.com/sigmah-dev/sigmah/commit/952e886b11ff50740a928182e8f2dffb3181b2c7

[4] http://wiki.sigmah.org/doku.php?id=contributorguide:preparerunningenvironment