Dependency injection with or without GIN.

[zakaria amine]

Hello everybody,

I am new to Sigmah project, but I have worked with GWT a lot, and I wanted sigmah developers opinion on dependency injection using GIN.

I noticed that Sigmah makes use of GIN heavily, and there some recommendations against it:

                         - GIN is not maintained anymore, GWT people recommend using Dagger ( available only for GWT 2.8)

                         - the compile time is longer 

                         - When I tried to launch dev mode, some NPE where thrown by GIN

                         - annotations are hanging everywhere

I have spent some days to remove the GIN and introduce manual dependency injection using a central factory interface and defered binding. Here is the commit: https://github.com/zak905/sigmah/commit/9b5030d4e519599139cd3d4bd2fd312f8d8a2a34

Now it is possible to launch the devmode.

What do you think? is removing GIN a good thing? 

[Olivier Sarrat]

Hi,

First of all, thank you very much for this big work!

Actually, I am not a GWT expert.
But after going quickly over GWT documentation on Dev mode, I feel like it would be a good thing to have this Dev mode possible for Sigmah. It would make Sigmah closer to standards expected from GWT applications.

Before merging, I would prefer to get some feedbacks from other senior developers in our community.
But we would need their feedbacks soon, because the more we wait, the more conflicts are created between your Pull Request and the master branch.

Best,

Olivier.

[zakaria amine]

Hi Olivier,

you are welcome :) I think dev mode will make developing on Sigmah more fast. I hope to get feedback from other developers as well. 

Cheers,

Zakaria