Space after %

[Ram Rachum]

It seems that it's possible to put a space between % and the tag name, like so:

    % extends 'base.shpaml'

I suggest that we change all our documentation to show code written like that, rather than %extends, because (a) it's nicer and (b) it's consisted with usage of =.

What do you think? 

Thanks,

Ram.

[Ram Rachum]

I was wrong; doing a space after % breaks. Do you agree to change Shapml to support a space after %?

Thanks,

Ram.

[Ram Rachum]

What do you think? 

--
You received this message because you are subscribed to a topic in the Google Groups "shpaml" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/shpaml/_zcBwt4uixE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to shpaml+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Ram Rachum]

Anyone? Again, I propose to change Shpaml to allow and recommend using a space after the %, like so:

    % block content

        % for user in users

I think this is better because other characters like > and = have space after them. It's ugly for me to see "%block", it looks wrong to me not to have that space there.

[James Robert]

I'm the primary maintainer these days, and I think it's a good idea, let's move forward with it :)

You received this message because you are subscribed to the Google Groups "shpaml" group.
To unsubscribe from this group and stop receiving emails from it, send an email to shpaml+un...@googlegroups.com.

[Steve Howell]

Not that my opinion counts, but I approve as well. :)

[Ram Rachum]

Thanks guys! Pull request submitted.

[James Robert]

Ram,

Thanks for your contributions, I needed to make a small tweak to ensure good test coverage and I also wanted to allow tabs wherever we allow spaces, so I made a small change to your regex update, but on the whole, this is great stuff.

I've created a new tag and I'm going to cut a release to pypi in the next hour or so :)

Thanks again,

James

[Ram Rachum]

My pleasure James! Thanks for making the release!