[should-dsl] improve failure messages

[Rodrigo Manhães]

Hi all,

I think the matchers' failure messages need a general improvement.

Now, the messages are something like "%r is[ not] %r". This leads to
freakish messages: "True is not True", "1 is equal to 1". This should
be replaced by something like "expected not True, got True" and
"expected not to equal 1, got 1".

This give us to 2 options:

1) All available matchers shall become classes.

2) The function matcher engine should change because in the
"expected/got" idiom, the "not" will appear in should_not failures,
not should ones. This leads us to another point: get rid of deprecated
features (but I will start another thread for this subject).

I prefer to convert everything to classes. What do you think?

[]'s
Rodrigo

Seguinte: estou pensando em dar uma geral nas mensagens de erro do
should-dsl. Só estou te mandando antes pq vai ser um trabalho manual
da porra e se há alguma consideração, é melhor que seja agora e não
depois... rs

As mensagens hoje são do tipo:

1 |should_not| be(1)

ShouldNotSatisfied: 1 is 1

Seria melhor algo como: 1 was not expected to be 1

ou

"[1, 2, 3] was expected to have 4" em vez de "[1, 2, 3] do not have 4"
(o que além de tudo está errado do ponto de vista do inglês).

Isto vai acarretar em uma das duas coisas:

1) Alterar

[Rodrigo Manhães]

All,

sorry, my last message was sent with a portuguese draft! Initially,
the e-mail would be sent only to Hugo. Then I decided send to the
list, but forgot to delete that piece.

If e-mail had unit tests, this would not happen... =P

[]'s
Rodrigo

2010/11/17 Rodrigo Manhães <rman...@gmail.com>:

[Hugo Lopes Tavares]

Hi Rodrigo,
Sorry for not giving you a faster reply.

The messages shoul be clearer, I agee. I need to think for a while
about the architecture.. I am applying a pull request, and I will be
bak to this thread asap.

[]s