[Shinken-devel] How to implement log_rotation_method=<n,w,m> ?

[Cedef]

Hi all,

I'm currently using Shinken v2.4 on production servers, and I'm annoyed by the
bug #1113 [1] as I cannot manage my log files the proper way, never being sure
where to look for.

I feel I could send you a patch in order to fully implement the
log_rotation_method. This could allow people to workaround #1113 while waiting
for a clean solution as suggested in the bug report. On my side, as a sysadmin,
I would prefer using logrotate to do this job.

I've started a small patch yesterday (see pull request #1649 [2]), but I've
closed my pull request today, figuring out that I've missed something:

log_rotation_method is a shinken.cfg parameter, but it applies to daemons
logging. To be exact, as written inside the documentation, it applies *only* to
broker daemon.

Could you give me some advice in order to implement correctly weekly, monthly
and 'none' log_rotation_method ?

Should'nt this parameter concern *all* daemons/*.ini files ? Because
Daemon.register_local_log() method, which instanciates the
TimedRotatingFileHandler is setup while initializing Daemon() instance...

Thanks a lot for your lights !

[1] https://github.com/naparuba/shinken/issues/1113
[2] https://github.com/naparuba/shinken/pull/1649
--
Cedef

------------------------------------------------------------------------------
_______________________________________________
Shinken-devel mailing list
Shinke...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel