Issue 105 in shellinabox: extend vt100.js to support xterm 256 colors
shell...@googlecode.com
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 105 by eleith: extend vt100.js to support xterm 256 colors
http://code.google.com/p/shellinabox/issues/detail?id=105
i really like my vim/screen/mutt/finch colors as defined by my server conf
files.
since vt100 emulators can support 256 colors by interpreting additional
escape codes sent by the server, i went ahead and implemented this on my
local copy of shellinabox.
the only changes i made were in vt100.js and some of the included css files.
with these updates, i can run screen/vim/mutt with full 256 color support
as per the color themes on the server. the css files i changed merely
provide the base 16 system colors as well as a default
background/front-color.
perhaps others would like this feature as well?
and btw, this is a great project, thanks for your work. i learned a lot
about terminal emulators going through your code...
Attachments:
vt100.js 150 KB
white-on-black.css 352 bytes
color.css 1.9 KB
shell...@googlecode.com
Comment #1 on issue 105 by eleith: extend vt100.js to support xterm 256
colors
http://code.google.com/p/shellinabox/issues/detail?id=105
i made the same changes in color.css to styles.css as well. basically i
just matched the 16 system colors to that of Terminal.app as found here:
http://en.wikipedia.org/wiki/Ansi_escape_codes#Colors
Attachments:
styles.css 4.9 KB
shell...@googlecode.com
Comment #2 on issue 105 by eleith: extend vt100.js to support xterm 256
colors
http://code.google.com/p/shellinabox/issues/detail?id=105
attaching newer vt100.js and styles.css, adding my changes into the version
in trunk, rather from the tar.gz versions which are outdated compared to
trunk.
Attachments:
vt100.js 171 KB
styles.css 7.3 KB
shell...@googlecode.com
Comment #3 on issue 105 by andy.chr...@gmail.com: extend vt100.js to
http://code.google.com/p/shellinabox/issues/detail?id=105
I have the vt100 & style.css a test today. They work great.
Thanks!
shell...@googlecode.com
Comment #4 on issue 105 by andy.chr...@gmail.com: extend vt100.js to
http://code.google.com/p/shellinabox/issues/detail?id=105
I have tested the vt100.js/styless.css today. They work great.
Thanks!
shell...@googlecode.com
Comment #5 on issue 105 by hinrik....@gmail.com: extend vt100.js to support
http://code.google.com/p/shellinabox/issues/detail?id=105
These patches are great. There still a few things that need to be improved,
though.
* The bgAnsi* classes in your color.css are setting 'color' when they
should be setting 'background-color'.
* An off-by-one error in two places in vt100.js is preventing ansi0 and
bgAnsi0 from being used at all.
* A logic error in vt100.js is causing it to incorrectly set the foreground
color to ansi7 for text which has the default color + bright attribute.
* When setting text to bold, you used "text-weight:bold;". It should
be "font-weight:bold;"
I have fixed all of the above, and attached the updated files.
Attachments:
color.css 1.4 KB
vt100.js 171 KB
shell...@googlecode.com
Comment #6 on issue 105 by beewoo...@gmail.com: extend vt100.js to support
http://code.google.com/p/shellinabox/issues/detail?id=105
Please provide a patch file instead of individual files.
shell...@googlecode.com
Comment #7 on issue 105 by superpo...@gmail.com: extend vt100.js to support
Hi, it is not working well here. Can you please make a test e report here?
There is a program in perl in the URL below to test terminal color
capabilities.
(http://mariusvw.com/2011/06/12/test-your-console-if-it-can-display-256-colors-with-perl/)
It works in putty and some other terminal. Does it work well with your
patch? I tried withou success.
Wait to hear from you.
Thanks
shell...@googlecode.com
Comment #8 on issue 105 by peng...@gmail.com: extend vt100.js to support
Would like to add that this is a highly anticipated feature - I had
installed Shellinabox but removed it because irssi became unusable.
shell...@googlecode.com
Comment #9 on issue 105 by mattderi...@yahoo.com: extend vt100.js to
I've implemented this different way... What about ESC]4 ? we need to be
able to alter the array of colors. This requires change in doControl's
logic. not sharing vt100.js because of mixed style
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
shell...@googlecode.com
Comment #10 on issue 105 by dic...@his.com: extend vt100.js to support
ESC]4 wouldn't follow the standard for control sequence (because it ends
with 4)
and would be nuisance to deal with in applications.
shell...@googlecode.com
Comment #11 on issue 105 by callan...@gmail.com: extend vt100.js to
I would really love to see this in the main repository. Any chance of that
happening soon? It's the only thing preventing us from using it in out VPN
portal.
shell...@googlecode.com
Comment #12 on issue 105 by beewoo...@gmail.com: extend vt100.js to support
The best way to see your change integrated is to pull the repository, make
your change and send me a pull request.
shell...@googlecode.com
Comment #13 on issue 105 by TruSktr: extend vt100.js to support xterm 256
colors
http://code.google.com/p/shellinabox/issues/detail?id=105
Please please please someone add the 256 color support. :D
shell...@googlecode.com
Comment #14 on issue 105 by TruSktr: extend vt100.js to support xterm 256
colors
http://code.google.com/p/shellinabox/issues/detail?id=105
Lots of people know how to edit javascript files, but not all know how to
create patches. As such, why don't you (project members) just make the
patch using the suggested files?
shell...@googlecode.com
Comment #15 on issue 105 by luka.kra...@gmail.com: extend vt100.js to
support xterm 256 colors
https://code.google.com/p/shellinabox/issues/detail?id=105
Hi, we have 256 color support added in our maintained fork. I think it
works ok :)
Please see: https://github.com/shellinabox/shellinabox