Re: Issue 51 in shellinabox: back quote key on the keyboard is not working

[shell...@googlecode.com]

Comment #1 on issue 51 by kloevschall: back quote key on the keyboard is
not working
http://code.google.com/p/shellinabox/issues/detail?id=51

^H works as expected but doesn't map to delete or back space

[shell...@googlecode.com]

Comment #2 on issue 51 by sandworm...@gmail.com: back quote key on the

keyboard is not working
http://code.google.com/p/shellinabox/issues/detail?id=51

This may be related, but my back ticks work fine, however the dash and
underscore do not. Has anyone seen the same or have a workaround?

[shell...@googlecode.com]

Comment #3 on issue 51 by sandworm...@gmail.com: back quote key on the

keyboard is not working
http://code.google.com/p/shellinabox/issues/detail?id=51

The above was in Fedora 17/Firefox 16.0.1/ShellInABox 2.14. Works fine in
Google Chrome, so I have my workaround. :)

[shell...@googlecode.com]

Comment #4 on issue 51 by Geldmach...@gmail.com: back quote key on the

keyboard is not working
http://code.google.com/p/shellinabox/issues/detail?id=51

I also have problems with the dash/underscore key. It looks like it might
be an issue with the newer versions of Firefox.
I was able to reproduce the problem with Firefox 18.0 on Ubuntu 12.04, and
18.0.1 on Windows XP.
But it worked fine with 13.0.1 on XP and Iceweasel (Firefox) 10.0.12 on
Debian Wheezy.

Also worked fine with Midori 0.4.7 on Ubuntu 12.04 and IE8 on XP.

Using Shellinabox 2.10 on Debian Wheezy.

[shell...@googlecode.com]

Comment #5 on issue 51 by sve...@krap.dk: back quote key on the keyboard is
not working
http://code.google.com/p/shellinabox/issues/detail?id=51

I have problems with firefox (version 21) too... Running version 2.14 of
shellinabox and in the Danish locale (at least) the following keys dont
work "-" ,"_" , "+", "?"

Most other special chars (pipes, hats, umlauts, tick and backtick) chars
work fine..

The above 4 works in Chrome

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[shell...@googlecode.com]

Comment #6 on issue 51 by gar...@garethwilliams.me.uk: back quote key on

the keyboard is not working
http://code.google.com/p/shellinabox/issues/detail?id=51

I've similar issues with Firefox (currently 26) where the '- and _' key and
the '# and ~' key (this is a United Kingdom English keyboard) don't work.
Again, fine on Chrome and even on IE8.

[shell...@googlecode.com]

Comment #7 on issue 51 by dementie...@gmail.com: back quote key on the
keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

@ (in Chrome) and | (in FF and Chrome) symbols are not working. Danish
keyboard layout.

[shell...@googlecode.com]

Comment #8 on issue 51 by anne.mar...@gmail.com: back quote key on the

[shell...@googlecode.com]

Comment #9 on issue 51 by dezz...@gmail.com: back quote key on the keyboard

is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

I almost fixed it - Both the FF bug and the Mac/Option key combinations.
The only thing I am unsure of is the fact that my Macbook sends "1B"+"40"
with Option. This is why @ and | fails. The (escape) in the front has to
go. There are many wrong ways to fix this - but I believe the fix has to be
somewhere around (Where the modifiers get added):
https://code.google.com/p/shellinabox/source/browse/shellinabox/vt100.js#2763
Maybe a fix would be to remove (hex) "1B" / ESCAPE character in front, when
a known Mac combination is pressed like "1B40" = @ ..

Other than that I fixed all ? + - _ keys by mapping them in vt100.js
handleKey/fixEvent - But this is meant for US keyboards exclusively -
either way the 171 keyCode (the new FF -_ keyCode) was missing and this was
why it wasn't working.

Works with Chromium / Firefox DK keyboard layout I tested Linux, Windows,
OS X.

Attachments:
vt100.js.patch 2.4 KB
vt100.js 171 KB

[shell...@googlecode.com]

Comment #10 on issue 51 by chr.aas...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

I fixed + ? - _ < > in Firefox and tested on Windows/Linux/OS X. The new
keyCodes are added in handleKey/fixEvent/keyDown.

For Macintosh keyboards it's a bit tricky it adds ESC in front of ALT
combinations (and all keys work without the "1B"/"ESCAPE" char in front
that gets added). I think there is a place for it in the code to get
handled, but I'm not sure where to put it right now so it interferes as
little as possible. I will be looking into a valid solution for Mac when I
have dug a little more in the source code and understand the addition of
modifier keys etc.


Attachments:
vt100.js 171 KB
vt100.js.patch 2.4 KB

[shell...@googlecode.com]

Comment #11 on issue 51 by chr.aas...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

The original issue is about the backtick/quote so I will try to address
that:

On my keyboard it reports as 187 in Chrome. I comment out case 187 in
handleKey:
//case 187: /* = */ ch = this.applyModifiers(61, event);
break;
(Which translates any ` or ´ to = - since they both trigger keyCode 187 at
first.)

And now it works for me also in Chrome without outputting = everytime ´ is
tapped. ("`=")

[shell...@googlecode.com]

Comment #12 on issue 51 by luka.kra...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

Hi,

we have fixes for -, _, #, ~, <, >, + and * characters integrated in our
fork on Github:
https://github.com/shellinabox/shellinabox

If you wish you can also create a pull request on our repo, as we are
trying to maintain
shellinabox project with latest fixes.

And a little warning: you are trying to fix to vt100.js file, which is auto
generated
from vt100.jspp. All you fixes will be over written when you update
vt100.jspp file. So you
should fix that file.

Bye :)

[shell...@googlecode.com]

Comment #13 on issue 51 by chr.aas...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

#12:

That sounds great. Can you use my fix for "?" in that case?

Do you have a comment on the Mac+OPTION situation? To keep it simple the
problem is as follows: 1B (hex) e.g. ESC is added to every ALT+
combination. Do you have a suggestion on where to put a condition? I was
thinking maybe something an if statement that said "IF ESC+@" or another
Mac key combination == strip ESC! Because I think the ESC hex char code is
intended from the original code?

I will be investigating the jspp file now ;)

[shell...@googlecode.com]

Comment #14 on issue 51 by luka.kra...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

#13:

Ok :)

I have taken another look at the issue and I found working patch in issue
202:
https://code.google.com/p/shellinabox/issues/detail?id=202#c23.

You just have to change the code in function keyDown(), for firefox to
detect new
keycodes as normal keys.

I have tested this patch on Slovenian, German and Danish keyboard and I
think it works
fine even for "?" sing :) Can you also test this patch on your keyboard? I
don't know what
kind of keyboard are you using :)

You can see commit here:
https://github.com/shellinabox/shellinabox/commit/3570f20b0b0db1909bf19685128ed3ae3a3445dd

As for the Mac, i don't really know what we should do yet. But I think i
saw something
on Github that has to do with this ... I will try to find it again and will
report back.

[shell...@googlecode.com]

Comment #15 on issue 51 by luka.kra...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

Hi, I am reporting back :)

I found this fix related to Mac:
https://github.com/JGRennison/shellinabox/commit/d62c3368094b679071cd62ffbbe4bbe970fb6f40

Please tell me if you can test this and it works for you. So I can
integrate it in our fork. For
testing you can just clone this fork:
https://github.com/JGRennison/shellinabox

[shell...@googlecode.com]

Comment #16 on issue 51 by chr.aas...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

With two above commits everything but ` ´ works.

https://github.com/JGRennison/shellinabox/pull/1

I served you this pull request ^

[shell...@googlecode.com]

Comment #17 on issue 51 by luka.kra...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

Hi, glad to hear you got it to work. But I have to tell you that this is
actually
not my fork :)

If you wish you can also issue pull request here:
https://github.com/shellinabox/shellinabox
This is the one that I take care of and I will happily accept your patch :)

But I think that on "shellinabox/shellinabox" fork we still need to
integrate changes from
commit d62c3368094b679071cd62ffbbe4bbe970fb6f40 ...

[shell...@googlecode.com]

Comment #18 on issue 51 by chr.aas...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

I made a new pull request now.

[shell...@googlecode.com]

Comment #19 on issue 51 by luka.kra...@gmail.com: back quote key on the

keyboard is not working
https://code.google.com/p/shellinabox/issues/detail?id=51

Ok, we have this fixed and tested on
https://github.com/shellinabox/shellinabox

Thanks and bye :)