[PATCH] store/plain: return err_to_sderr instead of SD_RES_EIO

3 views
Skip to first unread message

Meng Lingkun

unread,
Aug 15, 2016, 9:56:22 PM8/15/16
to sheep...@googlegroups.com, Meng Lingkun
default_move_object:SD_RES_EIO -> io_op_done:leave_cluster
will make the node leave the cluster, just because of a single
disk EIO. error_to_sderr can call md_handle_eio to fix it.

This can be tested by:
1. dog vdi create test 2G -P
2. dog vdi delete test &
3. echo 1 > /sys/block/sdX/device/delete

Signed-off-by: Meng Lingkun <mengl...@cmss.chinamobile.com>
---
sheep/store/plain_store.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sheep/store/plain_store.c b/sheep/store/plain_store.c
index fe4f84b..00307a8 100644
--- a/sheep/store/plain_store.c
+++ b/sheep/store/plain_store.c
@@ -449,8 +449,7 @@ int default_remove_object(uint64_t oid, uint8_t ec_index)
if (errno == ENOENT)
return SD_RES_NO_OBJ;

- sd_err("failed, %s, %m", path);
- return SD_RES_EIO;
+ return err_to_sderr(path, oid, errno);
}

return SD_RES_SUCCESS;
--
1.8.3.1



Meng Lingkun

unread,
Aug 15, 2016, 10:02:28 PM8/15/16
to sheep...@googlegroups.com, Meng Lingkun
default_remove_object:SD_RES_EIO -> io_op_done:leave_cluster
will make the node leave the cluster, just because of a single
disk EIO. error_to_sderr can call md_handle_eio to fix it.

This can be tested by:
1. dog vdi create test 2G -P
2. dog vdi delete test &
3. echo 1 > /sys/block/sdX/device/delete

Signed-off-by: Meng Lingkun <mengl...@cmss.chinamobile.com>
---
correct default_move_object to default_remove_object.

Liu Yuan

unread,
Aug 24, 2016, 4:19:07 AM8/24/16
to Meng Lingkun, sheep...@googlegroups.com
On Mon, Aug 15, 2016 at 07:01:17PM -0700, Meng Lingkun wrote:
> default_remove_object:SD_RES_EIO -> io_op_done:leave_cluster
> will make the node leave the cluster, just because of a single
> disk EIO. error_to_sderr can call md_handle_eio to fix it.
>
> This can be tested by:
> 1. dog vdi create test 2G -P
> 2. dog vdi delete test &
> 3. echo 1 > /sys/block/sdX/device/delete
>

Applied, thanks.

Yuan
Reply all
Reply to author
Forward
0 new messages