Bug in parsing arguments to <command>

[yatsura2k]

Hi,

While attempting to use ShadowSpawn with Rsync, I discovered a bug
in the parsing of
arguments to <command>.

Viz., Arguments beginning with '-' are interpreted as arguments to
ShadowSpawn itself,
rather than arguments to <command>. ShadowSpawn then fails the
operation, complaining
about an unknown argument.

This can be fixed in COptions.h, as follows:

-if (options._command.empty() && Utilities::StartsWith(arg, TEXT("/"))
|| Utilities::StartsWith(arg, TEXT("-")))

+if (options._command.empty() && (Utilities::StartsWith(arg,
TEXT("/")) || Utilities::StartsWith(arg, TEXT("-"))))

ShadowSpawn can then be successfully used with Rsync.

Regards,
Yatsura.

[Craig Andera]

Wow - a bug and a patch! You rock. Thanks for the contribution. I've
entered issue #14 [1], and I'd like to release an updated version at
some point that includes it. However, it will probably be at least
mid-December before I can make that happen.

Thanks again!

[1] https://github.com/candera/shadowspawn/issues/14