Issue 8 in google-sgnodemapper: TestRunner tweaks

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 8 by a...@spiralentertainment.com: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

TestRunner.java requires java 1.6 to run because of the .isEmpty() call.

If the round trip failed, resulting in a null value for the actualUrl, we
want to report an error, not
crash with a NPE.

Likewise, invalid test input (not enough tokens) can cause an
ArrayIndexOutOfBoundsException.

Attachments:
TestRunner.java.patch 1.7 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

Comment #1 on issue 8 by bradfitzgoog: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

I don't even see a TestRunner.java file anywhere in this project. What
file are you
patching?

[codesite...@google.com]

Comment #2 on issue 8 by D...@Newfield.org: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

sgnodemapper/embedding/java/com/google/code/sgnodemapper/TestRunner.java

[codesite...@google.com]

Comment #3 on issue 8 by ben.thesmith: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

I'm happy to take a look at this when I get a chance.

[codesite...@google.com]

Updates:
Status: Invalid
Owner: ben.thesmith

Comment #4 on issue 8 by ben.thesmith: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

Hey, looks like you've got a pretty old version of the code.

I rearrange the Java section about a year ago, Mavenised it and did pretty
much what you asked for in the patch.
The test runner is now here: http://code.google.com/p/google-
sgnodemapper/source/browse/trunk/embedding/java/src/test/java/com/google/code/sgnodemapper/NodeMa
pperTest.java

You should have a look at the latest checkout, or you can just use the
latest mvn release.

[codesite...@google.com]

Comment #5 on issue 8 by D...@Newfield.org: TestRunner tweaks
http://code.google.com/p/google-sgnodemapper/issues/detail?id=8

Weird. There must be something I don't understand about svn. You're
right, the whole tree based at
sgnodemapper/embedding/java/com is gone in newer checkouts, but updating my
existing checkout never
removed it. Thanks for taking a look!