[google-sgnodemapper] r215 committed - Add support for favIconUrlHttps and set this value for Google Sidewiki

1 view
Skip to first unread message

codesite...@google.com

unread,
Feb 18, 2010, 6:40:35 PM2/18/10
to sgnodemapp...@googlegroups.com
Revision: 215
Author: dpro...@google.com
Date: Thu Feb 18 15:39:56 2010
Log: Add support for favIconUrlHttps and set this value for Google Sidewiki
http://code.google.com/p/google-sgnodemapper/source/detail?r=215

Modified:
/trunk/nodemapper-base.js
/trunk/sites/google.js

=======================================
--- /trunk/nodemapper-base.js Wed Feb 17 15:40:25 2010
+++ /trunk/nodemapper-base.js Thu Feb 18 15:39:56 2010
@@ -66,6 +66,8 @@
* @param {Object} handler Object with functions as properties:
* 'name': the display name for the domain.
* 'favIconUrl': URL to the favicon that represents the domain.
+ * 'favIconUrlHttps': URL to the favicon that works over HTTPS. If
possible
+ * this should be the same as favIconUrl except for the scheme.
* 'urlToGraphNode': function(url,host,path) -> ident/URL (more coming
* in the future). A handler deals with parsing a URL to an sgn://
* URL, and also mapping from sgn:// URLs back to different classes of
@@ -632,6 +634,7 @@
* name: "Site!"
* [, notMassMarketSite: 1]
* [, favIconUrl: "http://path.to.site/favicon.ico"]
+ * [, favIconUrlHttps: "https://path.to.site/favicon.ico"]
* },
* ... ]
*/
@@ -656,6 +659,7 @@
domain: domain,
name: handler.name,
favIconUrl: handler.favIconUrl || '',
+ favIconUrlHttps: handler.favIconUrlHttps || '',
notMassMarketSite: nodemapper.handlers[domain].notMassMarketSite,
canGenerateFeedUrl: canGenerateFeedUrl
});
=======================================
--- /trunk/sites/google.js Tue Feb 16 12:08:14 2010
+++ /trunk/sites/google.js Thu Feb 18 15:39:56 2010
@@ -192,6 +192,7 @@
nodemapper.registerDomain("sidewiki.google.com", {
name: "Google Sidewiki",

favIconUrl: "http://www.google.com/sidewiki/intl/en/images/icon_yellowbubble.png",
+
favIconUrlHttps: "https://www.google.com/sidewiki/intl/en/images/icon_yellowbubble.png",
pkRegexp: /^\d{7,}$/,
identRegexp: /^[\w\.]{1,40}$/
});

Reply all
Reply to author
Forward
0 new messages