Let's say, for example, that I want to make a change to the Javascript
code. How would I go about doing that? Can I just commit it using svn?
If I do that, will it become live right away? Will anyone become
angry?
What about testing and making changes to the server-side (Python)
code?
Do you have any sort of QA or test environment to test changes in?
You won't be able to commit any code unless someone adds you to the
project's list of developers allowed to make changes to the code.
Changing the code in subversion will not affect the live site.
You'll need a google code account set up first. Amar will have to add
you to the list or give me or someone permission to add you. In the
meantime you can submit patches to the list.
I believe all of the server side code can be tested locally.
John
> --
> You received this message because you are subscribed to the Google Groups "sf-bike-planner" group.
> To post to this group, send email to sf-bike...@googlegroups.com.
> To unsubscribe from this group, send email to sf-bike-plann...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/sf-bike-planner?hl=en.
>
>
I will look for the find_path.py. There is a lot of code and I still
haven't looked through it and familiarized myself with all of it yet.
I am a bit confused about the front-end stuff. If I am trying to make
a change to the trunk, should I FTP it, or commit it using svn? Will
FTPing it make it live? Will committing it make it live? I just want
to know what this stuff does to avoid messing up anything.
What pylibs are you referring to? I googled "pylibs" and didn't see
anything that looked relevant.
I don't have a local server, AFAIK. Do I need to install Apache or a
similar program for this?
I will look into the review mechanism when I get a chance.
> > On Tue, Jan 26, 2010 at 5:03 PM, Elias <mikez...@gmail.com> wrote:
> > > I became a member of the Google group to be able to work on this
> > > project, and checked out the source code using svn. I have some
> > > programming experience, but I have never worked on an open-source
> > > project.
>
> > > Let's say, for example, that I want to make a change to the Javascript
> > > code. How would I go about doing that? Can I just commit it using svn?
> > > If I do that, will it become live right away? Will anyone become
> > > angry?
>
> > > What about testing and making changes to the server-side (Python)
> > > code?
>
> > > Do you have any sort of QA or test environment to test changes in?
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > "sf-bike-planner" group.
> > > To post to this group, send email to sf-bike...@googlegroups.com.
> > > To unsubscribe from this group, send email to
> > sf-bike-plann...@googlegroups.com<sf-bike-planner%2Bunsu...@googlegroups.com>
> > .
> > > For more options, visit this group at
> >http://groups.google.com/group/sf-bike-planner?hl=en.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "sf-bike-planner" group.
> > To post to this group, send email to sf-bike...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > sf-bike-plann...@googlegroups.com<sf-bike-planner%2Bunsu...@googlegroups.com>
Just to clarify, are you saying you added me as a committer?
I am a bit confused about the front-end stuff. If I am trying to make
a change to the trunk, should I FTP it, or commit it using svn? Will
FTPing it make it live? Will committing it make it live? I just want
to know what this stuff does to avoid messing up anything.
What pylibs are you referring to? I googled "pylibs" and didn't see
anything that looked relevant.
I don't have a local server, AFAIK. Do I need to install Apache or a
similar program for this?
To unsubscribe from this group, send email to sf-bike-plann...@googlegroups.com.
As a test, I tried making a trivial change to the site (I added a
comment to the file bikemap.html), uploading it via FTP, and reloading
the site, and I didn't see the change. Is this supposed to happen?
> > <sf-bike-planner%2Bunsu...@googlegroups.com<sf-bike-planner%252Buns...@googlegroups.com>
>
> > > > .
> > > > > For more options, visit this group at
> > > >http://groups.google.com/group/sf-bike-planner?hl=en.
>
> > > > --
> > > > You received this message because you are subscribed to the Google
> > Groups
> > > > "sf-bike-planner" group.
> > > > To post to this group, send email to sf-bike...@googlegroups.com.
> > > > To unsubscribe from this group, send email to
> > > > sf-bike-plann...@googlegroups.com<sf-bike-planner%2Bunsu...@googlegroups.com>
> > <sf-bike-planner%2Bunsu...@googlegroups.com<sf-bike-planner%252Buns...@googlegroups.com>
To unsubscribe from this group, send email to sf-bike-plann...@googlegroups.com.
* I replaced the getURLParam function with one that is simpler and
that properly handles spaces and escaping.
* I added the mobile CSS class for the body element, like you were
apparently planning to do, according to the comments.
* I removed the "if (status != 'success')" checks from the callback
functions. They are not needed since the functions only run if the
request was successful. I am planning to come up with a more reliable
way to handle errors.
* I used jQuery functions instead of plain Javascript to simplify the
code somewhat.
* I changed the spacing and indenting of some of the files, to make
them more consistent and easier to read. Does anyone mind me doing
this? Are there any sort of style guidelines or rules I should follow?
Other minor stuff.
Most of these things are not visible to the user. They are just there
to simplify the code. Let me know what you think.
Great to hear you've made some improvements. The javascript was
mostly written by me in a hurry. I started using jQuery but as you
can see from the code I was sort of making it up as I went along.
Feel free to reformat in a reasonable way.
Here's a link you can use for review:
http://code.google.com/p/sf-bike-planner/issues/entry?show=review&former=sourcelist
I've never tried it before to be honest. If it doesn't work out you
can always send a diff of the relevant files. Assuming it looks good,
you can check it into trunk. When we've accumulated sufficient
changes to merit a new release we can merge to live and finally ftp to
amarpai.com/bikemap.
cheers
Amar
On Feb 13, 3:45 pm, Amar Pai <jcrue...@gmail.com> wrote:
> Hi Elias,
>
> Great to hear you've made some improvements. The javascript was
> mostly written by me in a hurry. I started using jQuery but as you
> can see from the code I was sort of making it up as I went along.
> Feel free to reformat in a reasonable way.
>
> Here's a link you can use for review:
>
> http://code.google.com/p/sf-bike-planner/issues/entry?show=review&for...
> > For more options, visit this group athttp://groups.google.com/group/sf-bike-planner?hl=en.
What does that mean???
> What did you put in the code review request field "Branch Path:" ? Did you
> leave it as the default '/branches' ? Maybe it filled in the first
> available branch, which is live.
>
I tried submitting the form with the default, but it wouldn't let me,
so I tried entering "/branches/live". At least that is what I think I
did. I don't remember for sure.
> Their stupid code review seems to be set up primarily for the case where
> you're working in your own branch, like /branches/elias/, with the
> expectation that upon successful review you'd merge your changes to trunk.
> That seems too complicated given that we're the only devs working in this
> codebase at the moment. So hopefully we can get it to work without
> needing additional branches.
>
> Can you try resubmitting the code review request using branch path '/trunk'
> ? If that doesn't work, can you try empty branch path?
>
> If all else fails, you can just run "svn diff" in your root svn dir and send
> that output to this mailing list, and we can review that way.
>
> thanks
>
> Amar
>
I am about to try your suggestions.