Issue 256

[Dmitry Los]

GitHub issue: https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/256

I've made examples of configuration for this issue

https://gist.github.com/melodicwing/0b100b669ca6927c16d4

What to do next?

[Roman Ivanov]

you can start development, your check should be extended from AbstractFileSetCheck , example: https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineCheck.java​

[Dmitry Los]

I was looking into implementation of example check https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineCheck.java#L46

came a question about implementation of method processFlitered() in my issue

if I inderstand right, instead of detector.processLines(lines); I need apply reg.exp on the file name which i got from the input parameter 'file', right?

and what about error messages? i don't see where i should describe it

[Roman Ivanov]

Hi Dmitriy,

>  got from the input parameter 'file', right?

yes you need use only "file" variable , you do not need "lines".

> i don't see where i should describe it

I am not sure that I understand a question, but...

message is set at https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineCheck.java#L62

message is provided as parameter:

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/SinglelineDetector.java#L64

location of all messages:

checkstyle/src/main/resources/com/puppycrawl/tools/checkstyle/checks/regexp/messages.properties

=================

Please let me know if smth is still unclear.

thanks,

Roman Ivanov 

​

[Dmitry Los]

One more question:

in which folder should i put sources with my check?

[Roman Ivanov]

Hi Dmitry,

In main project all similar Checks are located in "checks" package - https://github.com/checkstyle/checkstyle/tree/master/src/main/java/com/puppycrawl/tools/checkstyle/checks .

So please put your check to https://github.com/sevntu-checkstyle/sevntu.checkstyle/tree/master/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks

Thanks,
Roman Ivanov

[Dmitry Los]

Hi, Roman

There're 5 folders at https://github.com/sevntu-checkstyle/sevntu.checkstyle/tree/master/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks

in which should i put my check?

Thanks

[Roman Ivanov]

No need to move to subfolder, just place java file in that folder

--
You received this message because you are subscribed to the Google Groups "Sevntu Checkstyle" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sevntu-checkst...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Dmitry Los]

Hi, Roman.

There one more question: what class should i use for cheking filename? SinglelineDetector or something else?

Thanks.

[Roman Ivanov]

Example of file name validation is there https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/OuterTypeFilenameCheck.java#L69 , you do not need use other classes just copy code from them.

SinglelineDetector was referenced by me as example of how report an violation.

--