Is sevntu sandbox actual for now?

[Pavel Baranchikov]

Hello!

I've implemented EnumValueNameCheck in February 2014 - about a year ago. I was informed, that all the new checks are to be placed in sandbox project before committing them to the main Checkstyle project.
During last 2-3- months I see vast new checks implemented in Ceckstyle main project, but my EnumValueNameCheck is not moved to main project.

Looks, like EnumValueNameCheck is forgotten. Should I make pull request to main project to propagate the check there?

Best regards,
Pavel.

[Roman Ivanov]

HI Pavel,

All new Checks that appear in Checkstyle were created due to GSoC activity, and we had to implement and seriously test them directly in checkstyle project.

There are NO other new Checks that come to main library during that year. I have a lot of requests for new Checks but rule is strict for all.

Your Check is not forgotten, I even have issue to it, that I still did not found time to formulate and put in public, I will do in next few weeks for sure.

Please do not propagate it to main library for now.

​thanks,

Roman Ivanov

[Roman Ivanov]

Hi Pavel,

I share with you my note, I do not have time right now to think a more about it, but if you have time, please think about it. 

Checkstyle - update for Enum name , read

http://java67.blogspot.com/2014/04/what-java-developer-should-know-about-Enumeration-type-in-Java.html?m=1

, we need to change ClassEnum detection algorithm: enum that implemnetes interface, override of Enum class methods should not be reason to become ClassEnum.

That note I did few months ago, please review an article and let me know if my notes a incorrect.

thanks,

Roman Ivanov

​

[Pavel Baranchikov]

, we need to change ClassEnum detection algorithm: enum that implemnetes interface, override of Enum class methods should not be reason to become ClassEnum.

This is the same theoretical discussion,as naming of final static fields: there are several points of view on what is constant.

BTW, we did not manage to use the ClassEnum of ConstantEnum distinguish for internal usage in our company. So, maybe the distinguish code should be removed at all, forcing user just to specify regexp, which should default to

^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|([a-z][a-zA-Z0-9]*)$

(either CamelNotation or UPPERCASE_NOTATION)

Best ragards,
Pavel.

[Roman Ivanov]

Hi Pavel, 

that is good example why sandbox project is required :) .

please remove code that will not work properly.

Please make by default such pattern to not conflict with Spring and hibernate - there a lot of Enums there.

thanks ,

Roman Ivanov

[Pavel Baranchikov]

Hi, Roman

that is good example why sandbox project is required :) .

Yes. Agree.
 

please remove code that will not work properly.

Please make by default such pattern to not conflict with Spring and hibernate - there a lot of Enums there.

Implemented PR  - https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/370

[Roman Ivanov]

Hi Pavel,

I put my comments  https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/370#issuecomment-142363615

thanks,

Roman Ivanov

​