Sevntu Checkstyle 1.16.0

30 views
Skip to first unread message

RomanIvanov

unread,
Oct 25, 2015, 9:09:27 PM10/25/15
to Sevntu Checkstyle
http://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.16.0

New:
SingleSpaceSeparatorCheck -  Checks that if tokens are separated by whitespaces, it has to be a single space.

Misc:
version bump -  Update Maven Checkstyle Plugin to 2.17 .

Tom Verhoeff

unread,
Feb 15, 2016, 5:41:46 AM2/15/16
to Sevntu Checkstyle, Tom Verhoeff
Hi,

When will this check appear in the Checkstyle at http://checkstyle.sourceforge.net so that we can use it in NetBeans via Checkstyle Beans?

Thanks,

Tom

Roman Ivanov

unread,
Feb 15, 2016, 8:56:22 AM2/15/16
to sevntu-c...@googlegroups.com, Tom Verhoeff
Hi Tom,

We are still in moratorium period in main project, testing tool is still in development.

There is an additional note - https://groups.google.com/d/msg/checkstyle-devel/JbhfiiSqKsQ/2vkapmxkDgAJ that could let you force introduction of new Check to main project.


thanks,
Roman Ivanov

Michał Kordas

unread,
Feb 17, 2016, 12:41:29 PM2/17/16
to sevntu-c...@googlegroups.com, Tom Verhoeff
Hey Roman,

I agree with Tom, I'd also really like to move this check to main repo as it is super-useful and confirmed as reliable in couple of my projects. Would you accept PR from me?

Thanks,
Michal

--
You received this message because you are subscribed to the Google Groups "Sevntu Checkstyle" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sevntu-checkst...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Roman Ivanov

unread,
Feb 17, 2016, 1:14:33 PM2/17/16
to sevntu-c...@googlegroups.com, Tom Verhoeff

Michal, Did you fix 5 bug after i changed moratorium rules ?

Michał Kordas

unread,
Feb 17, 2016, 1:57:20 PM2/17/16
to sevntu-c...@googlegroups.com
No, I haven't. I've fixed multiple bugs before rule change.

Roman Ivanov

unread,
Feb 17, 2016, 3:05:46 PM2/17/16
to sevntu-c...@googlegroups.com
Michal, you already did new Check introduction at http://checkstyle.sourceforge.net/releasenotes.html#Release_6.14

> new CatchParameterName Check: to validate names of catch-block parameters only. Author: Michal Kordas #2616

There was no functional bug fixes after that (or I do not see them). I appreciate your contribution to Checkstyle. 
But rule is simple and you already agree on it. So lets do not brake rules, lets fix bugs.

I did not fix functional bugs recently too, I have no right to introduce new Checks, I have about 30 of them in Sevntu. 
Believe me, I have the most incentive in the world to start new Checks introduction to main library. 

I am not able to do new Checks too as I do not fix bugs for months ... and just spend whole my time to let other do this easily.

To make it short: please fix 5 functional bugs and you are welcome with new Check.

Michal Kordas

unread,
Feb 17, 2016, 4:19:53 PM2/17/16
to sevntu-c...@googlegroups.com

Sure, agreed on the rule, but I will not find time for that, so maybe someone else can pick this up?

--

Roman Ivanov

unread,
Feb 17, 2016, 4:20:55 PM2/17/16
to sevntu-c...@googlegroups.com
yes, such "hero" is always welcome.
Reply all
Reply to author
Forward
0 new messages