> |
* Sets how many characters in a literal there must be before it checks for an underscore |
|
*/ |
public void setMinDecimalSymbolLen(int len)
|
|
please use @param and @return for all methods, that is requirement of main projects, just to avoid extra fixes during transition to main project.
3)
private boolean passesCheck(String rawLiteral) |
|
{ |
|
int minCheckingLength = minSymbolsBeforeChecking(rawLiteral); |
|
int symbolsUntilUnderscore = maxSymbolsUntilUnderscore(rawLiteral); |
String[] numericSegments = getNumericSegments(rawLiteral);
| Please make declaration of method base on first usage in code, so passesCheck, minSymbolsBeforeChecking, maxSymbolsUntilUnderscore, getNumericSegments .
|
4)
Please make "2" as constant, you use it in 3 places and 2 methods.
5)
private String[] getNumericSegments(String rawLiteral) |
Type type = getNumericType(rawLiteral); |
Please move "Type type = getNumericType(rawLiteral);" to upper level in this and other methods.
6)
I updated name of issue " new Check: NumericLiteralNeedUnderscoreCheck #187 ", please make commit message as "Issue #187: new Check - NumericLiteralNeedUnderscoreCheck". This will ease search for a commit in future.
7)
As all these minors from above resolved, I will merge your contribution and do release right-away. Thanks for your help.
thanks,
Roman Ivanov