OrmLite: SqliteNET projects missing the ExpressionVisitor override

[Brannon]

The Sqlite32/64 projects were missing the override of ExpressionVisitor. It's a pretty nasty bug. I added a fix for this to my Pull Request. 

However, it's a fundamental failing of the copy-paste scenario we've got going on with the three Sqlite implementations. All three of them should reference the same code aside from the one method that's different in each. I'm okay if this is done through the "Add as Link" ability (assuming we don't want to seriously consider a single Sqlite implementation where the user is forced to specify/load the platform-specific dependency). And of course tests should exist for as much functionality as possible, including the LINQ support.

What was the purpose of supporting both System.Data.SQLite and Mono.Data.SQLite ?

Also, the SLN changes in my pull request were just add back the few projects that weren't selected in the build configuration (both debug and release). I don't know why they weren't selected as they build fine...

[Demis Bellot]

k kool, linking single source file sounds like a winner, will check the pull-reqs out tonight.

 

What was the purpose of supporting both System.Data.SQLite and Mono.Data.SQLite ? 

ServiceStack.OrmLite.Sqlite is the only project that works on .NET + Mono and as such is the Sqlite project used in all of ServiceStack examples that use Sqlite.

The other SqliteXX projects are to make it easier to work in Win 32 + 64 environments as having it reference the unmanaged sqlite means you can get in weird situations where IIS/WebDevServer keeps a lock to the external unmanaged sqlite.dll that you can seem to only free by restarting it. It doesn't happen when the unmanaged dll is embedded in a .NET assembly.

--
- Demis

http://twitter.com/demisbellot

http://www.servicestack.net/mythz_blog

[Brannon]

On Wednesday, March 7, 2012 4:28:10 PM UTC-7, mythz wrote:

k kool, linking single source file sounds like a winner, will check the pull-reqs out tonight.

I just added a pull request for linking the source files. That should avoid any copy/paste errors on the sqlite projects in the future.

[Demis Bellot]

k thx merged.