RabbitMqSink review

[Steffen Sun Lyng]

Hi all

I added a RabbitMqSink repo. Maybe someone could review this and tell me if something is missing -- the implementation hasn't been thoroughly tested, but it's stable enough for some test-runs.

https://github.com/sonicjolt/serilog-sinks-rabbitmq

Thanks

[nblum...@nblumhardt.com]

Hi Steffen!

I'm a huge fan of Rabbit, so it was great to see this pop up :-)

I've added a few comments after a brief pass over the code, hope this helps.

Cheers,
Nick

[Steffen Sun Lyng]

Thanks Nick

I'll look into your comments, and fix them

Does this need alot of work to be ready for a PR ?

This is my first contribution to OSS.

/Steffen

[nblum...@nblumhardt.com]

Hi Steffen,

It's looking great. Currently the way the Serilog project runs is that we encourage sink authors to self-publish and get some feedback/usage before we offer to bring it under the serilog root project's umbrella (the number of sinks grew so explosively that maintaining them centrally became a significant burden).

I think the code is looking good. The next steps would be:

• Create a .NUSPEC file for the package like this one: https://github.com/serilog/serilog-sinks-literate/blob/dev/src/Serilog.Sinks.Literate/Serilog.Sinks.Literate.nuspec
• Publish the package on nuget.org
• Set up an AppVeyor CI build that automatically builds and publishes packages out of your master branch

Once it's had some use in the wild it'd definitely be worth an inclusion in the Serilog project - once you feel it's battle-tested please do raise an issue on the Serilog tracker for this purpose. In the meantime to help raise the profile of the project I've listed it here on the Serilog wiki:

https://github.com/serilog/serilog/wiki/Provided-Sinks#third-party

Let me know if you need a hand with anything!

Nick