Validate 1.1 APIs (was: semantics of cert chain callback)

[Greg Stein]

On Apr 20, 2012 3:45 AM, "Andre Fischer" <andrefi...@googlemail.com> wrote:
>
> On 20.04.2012 06:32, Greg Stein wrote:
>...
>> I've updated the callback in r1598, and ported it over to
>> branches/1.1.x in r1599.
>>
>> Could you take a look and maybe try it out? Assuming there are no
>> problems, then I'll go ahead and cut a 1.1 release next week.
>>
>> Andre: could you see whether AOO could use the new APIs on the 1.1.x
>> branch? You should be able to avoid chunked requests by using the new
>> serf_bucket_request_set_CL(), and this new chain stuff should be able
>> to replace the local patch that you apply.
>
>
> We are currently in the process of finishing our first release of Apache OpenOffice (incubating), so it is not a good time for updating libraries right now.  I will look into this when the release is out.

Could you take a look? I'd really appreciate it. I'll be able to make the 1.1 release if these APIs work for AOO. (and then I can finish some Subversion work)

Thx,
-g

[Andre Fischer]

Hi Greg,

Sorry for the delay.

I was not yet successful with building serf-1.1 inside the AOO build system.  The reason for that is serfs change  from autoconf/automake to scons.

We do not yet have scons as build requirement and I would not like to add it now (even though it may be a better choice than our mixture of different build tools.)  One reason is that I did not find a binary for MacOSX or Debian based Linuxes.

In the long run this should not be a big problem.  We already use our own makefiles to build serf on Windows.  Doing the same on the other platforms should be possible.

So, I would suggest that you go ahead with releasing serf and we (I) will then integrate the new version into AOO.

Andre

[Justin Erenkrantz]

It sure sounds like you might be trying trunk (2.x) rather than the 1.1 branch as scons should only be the default on trunk.  1.1 should still have autoconf.  -- justin

--
You received this message because you are subscribed to the Google Groups "Serf Development List" group.
To post to this group, send email to serf...@googlegroups.com.
To unsubscribe from this group, send email to serf-dev+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/serf-dev?hl=en.

[Greg Stein]

On Wed, May 30, 2012 at 9:43 AM, Andre Fischer
<andrefi...@googlemail.com> wrote:
>...
> So I checked out the 1.1 branch via  svn checkout
> http://serf.googlecode.com/svn/branches/1.1.x/ serf-1.1.x.
> There are still changes to the build system: configure and build/serf.def
> are missing but there is a buildconf script that can create both.
>
> That means that I still have to adapt our makefiles.
>
> I will get back to you when I am done.

When I construct the actual serf 1.1 release, the configure and
serf.def files will be present. So your build scripts should not need
to run buildconf.

They are only missing because you're working directly from trunk. You
could create a pretend tarball using buildconf (easier) or dist.sh
(harder, but will be how I create the distribution tarball).

If you can test and say the new code works, then I can do the 1.1
release, and then you can commit changes that work against the 1.1
release tarball (ie. don't commit stuff that works against the
branch!)

Please feel free to ask, if you have any questions!

Cheers,
-g

[Andre Fischer]

I was partially successful: I can compile and link the serf library
into AOO with only a few changes to our code.

I just have not been able yet to run it due to problems with our
internal crypto and certificate libraries. (I usually don't use it and
therefore don't build it. It would probably suffice to rebuild the whole
office but that takes a couple of hours. And there are always several
other things that have to be done. Maybe next week.)

But all that is not a problem of serf. I you want to wait till next
week then I will continue to work on it. Otherwise everything looks
good as far as I could test it and you may want to go ahead with your
release.

I am sorry for the delay,
Andre

[Greg Stein]

On Jun 1, 2012 12:02 PM, "Andre Fischer" <andrefi...@googlemail.com> wrote:
>...

> But all that is not a problem of serf.   I you want to wait till next week then I will continue to work on it.  Otherwise everything looks good as far as I could test it and you may want to go ahead with your release.

I can wait until next week. I'd really like to know that you can remove all your local serf patches, and have AOO use a standard serf build.

I appreciate you looking into this. Thanks!

Cheers,
-g

[Andre Fischer]

Finally, we are done :-)  Oliver and I have made the necessary changes to the AOO code and have verified that everything is still working with the new serf release.  And we do not need a single patch anymore.  Thank you.

So, I am looking forward to your new release,

Andre

Cheers,
-g

[Greg Stein]

On Thu, Jun 7, 2012 at 4:25 AM, Andre Fischer
<andrefi...@googlemail.com> wrote:
>...

> Finally, we are done :-)  Oliver and I have made the necessary changes to
> the AOO code and have verified that everything is still working with the new
> serf release.  And we do not need a single patch anymore.  Thank you.

Awesome!

Thank you guys for taking the time to work through this. That is the
answer that I was hoping for. "No more patches". Nice.

I'll put together the 1.1 release tomorrow.

Cheers,
-g

[Justin Erenkrantz]

On Thu, Jun 7, 2012 at 10:29 AM, Greg Stein <gst...@gmail.com> wrote:
> Awesome!
>
> Thank you guys for taking the time to work through this. That is the
> answer that I was hoping for. "No more patches". Nice.
>
> I'll put together the 1.1 release tomorrow.

I just did a sanity check here of the 1.1.x tree and all looks good here.

If you need any help with the release, scream.

Thanks! -- justin