Issue 167 in serf: Calling AcquireCredentialsHandle using unicode strings

[se...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 167 by benjamin...@gmail.com: Calling AcquireCredentialsHandle
using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

According to [1], function AcquireCredentialsHandle should be called using
unicode strings:

' #Remarks
'
' [...]
'
' - The two string parameters must be Unicode strings.

So instead of using a regular char*, shouldn't
`serf__spnego_create_sec_context() ` use a wchar_t pointer like this:

```
const wchar_t* sspi_package = L"Negotiate"; /* or L"NTLM" */
```

[1]
https://msdn.microsoft.com/en-us/library/windows/desktop/aa374712(v=vs.85).aspx

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[se...@googlecode.com]

Comment #1 on issue 167 by i...@visualsvn.com: Calling

AcquireCredentialsHandle using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

Serf uses ansi version of AcquireCredentialsHandle -
AcquireCredentialsHandleA() since revision r2005.

[se...@googlecode.com]

Comment #2 on issue 167 by benjamin...@gmail.com: Calling

AcquireCredentialsHandle using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

Oh sry, somehow missed that trailing A. Thanks for your quick response!

[se...@googlecode.com]

Comment #3 on issue 167 by benjamin...@gmail.com: Calling

AcquireCredentialsHandle using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

Now I see... I was using the latest tagged serf version (1.3.8), which
isn't yet calling the ansi version of that method.

r2005 was committed 3 days after the 1.3.x branch has been created and it
seems it never has been merged. Is this intended for compatibility
considerations? Or do you think it was just forgotten and could be merged?

[se...@googlecode.com]

Comment #4 on issue 167 by chem...@gmail.com: Calling

AcquireCredentialsHandle using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

I think it just forgotten. I don't see reasons why this change cannot be
merged to 1.3.x branch.

[se...@googlecode.com]

Updates:
Status: Fixed

Comment #5 on issue 167 by lieven....@gmail.com: Calling

AcquireCredentialsHandle using unicode strings
https://code.google.com/p/serf/issues/detail?id=167

Closing as fixed, to be included in the 1.4.0 release.