MySQL Encoding Help Requested

6 views
Skip to first unread message

Jeremy Evans

unread,
Jun 4, 2010, 11:07:56 AM6/4/10
to sequel-talk
Between 3.11.0 and 3.12.0 I made a change to the the way the encoding
was set in the MySQL adapter (http://github.com/jeremyevans/sequel/
commit/0adf8f14371fccff213cc9cd347611e642e32e44). This fixed the OPs
case, but it appears to have broken other cases. One workaround that
fixes both cases is making it so Sequel does not read the client
default group by default, but I think that would break backwards
compatibility for people that are relying on that feature.

Anyway, if you use MySQL and understand the issues, please take a look
at http://code.google.com/p/ruby-sequel/issues/detail?id=300 and add
your comments.

If I don't get any responses, I'll probably end up reverting the
previous patch and not reading the client default group by default,
using the patch at (http://pastie.org/967778.txt).

Jeremy

Jeremy Evans

unread,
Jun 7, 2010, 2:32:32 PM6/7/10
to sequel-talk
On Jun 4, 8:07 am, Jeremy Evans <jeremyeva...@gmail.com> wrote:
> Between 3.11.0 and 3.12.0 I made a change to the the way the encoding
> was set in the MySQL adapter (http://github.com/jeremyevans/sequel/
> commit/0adf8f14371fccff213cc9cd347611e642e32e44).  This fixed the OPs
> case, but it appears to have broken other cases.  One workaround that
> fixes both cases is making it so Sequel does not read the client
> default group by default, but I think that would break backwards
> compatibility for people that are relying on that feature.
>
> Anyway, if you use MySQL and understand the issues, please take a look
> athttp://code.google.com/p/ruby-sequel/issues/detail?id=300and add
> your comments.
>
> If I don't get any responses, I'll probably end up reverting the
> previous patch and not reading the client default group by default,
> using the patch at (http://pastie.org/967778.txt).

Thanks to some advice from tmm1, this got sorted out:
http://github.com/jeremyevans/sequel/commit/a9115795dbae1c7d518ebd4341e6d674b97a8780

I'm willing to do a 3.12.1 release for just this patch if there will
be a lot of people affected by this (I honestly don't know), so if you
would like a point release made, please speak up here.

Jeremy

Ricardo Chimal, Jr.

unread,
Jun 9, 2010, 3:34:22 PM6/9/10
to sequel-talk
A sequel 3.12.1 release would be really helpful for the taps project.
I've already got a reports of this specific issue affecting various
people.

Thanks

--
Ricardo


On Jun 7, 11:32 am, Jeremy Evans <jeremyeva...@gmail.com> wrote:
> On Jun 4, 8:07 am, Jeremy Evans <jeremyeva...@gmail.com> wrote:
>
> > Between 3.11.0 and 3.12.0 I made a change to the the way the encoding
> > was set in the MySQL adapter (http://github.com/jeremyevans/sequel/
> > commit/0adf8f14371fccff213cc9cd347611e642e32e44).  This fixed the OPs
> > case, but it appears to have broken other cases.  One workaround that
> > fixes both cases is making it so Sequel does not read the client
> > default group by default, but I think that would break backwards
> > compatibility for people that are relying on that feature.
>
> > Anyway, if you use MySQL and understand the issues, please take a look
> > athttp://code.google.com/p/ruby-sequel/issues/detail?id=300andadd
> > your comments.
>
> > If I don't get any responses, I'll probably end up reverting the
> > previous patch and not reading the client default group by default,
> > using the patch at (http://pastie.org/967778.txt).
>
> Thanks to some advice from tmm1, this got sorted out:http://github.com/jeremyevans/sequel/commit/a9115795dbae1c7d518ebd434...

Jeremy Evans

unread,
Jun 9, 2010, 4:05:33 PM6/9/10
to sequel-talk
On Jun 9, 12:34 pm, "Ricardo Chimal, Jr." <rica...@heroku.com> wrote:
> A sequel 3.12.1 release would be really helpful for the taps project.
> I've already got a reports of this specific issue affecting various
> people.

OK. I'll put one together today.

Thanks,
Jeremy
Reply all
Reply to author
Forward
0 new messages