bug in the R code

[Wei]

Dear SeqBuster,

I just downloaded the latest SeqBuster (revision 38) and I like this
tool. But I notice there are some bugs in the R code (at line 19 of
the file freqDistribution.R):

The original code:
if (is.null(list$freq1)==F){
temp<-unlist(strsplit(list$freq1," "))
options<-paste(sep=" ","where `freq` >",list$freq1," AND")
}else{
options<-"where `freq` > 0 AND"
}
if (is.null(list$freq2)==F){
temp<-unlist(strsplit(list$freq2," "))
options<-paste(sep=" "," `freq` <",list$freq2," AND")
}

My revision:
if (is.null(list$freq1)==F){
temp<-unlist(strsplit(list$freq1," "))
options<-paste(sep=" ","where `freq` >",list$freq1," AND")
}else{
options<-"where `freq` > 0 AND"
}
if (is.null(list$freq2)==F){
temp<-unlist(strsplit(list$freq2," "))
options<-paste(sep=" "," `freq` <",list$freq2," AND")
}

I also ran into some other problems when playing with the demo data
and I have not figured out the reason. I do notice that there might
be some issue in the translation between your java GUI and the DB
query. It would be wonderful if you could display last SQL statement
when an error occurs rather than direct users to the .Rout files.

Thanks,

Wei Zhu

[Lorena Pantano]

Hi,

thanks a lot for your time.

I am trying to debug all posible bugs, so your comments are great. If you find different bugs, please let me know, it would help to others. I just fix this one.

I will note your suggestion about give the last sql statement for the next update. Normally i change seqbuster every two months.

--
You received this message because you are subscribed to the Google Groups "SeqBuster" group.
To post to this group, send email to seqb...@googlegroups.com.
To unsubscribe from this group, send email to seqbuster+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/seqbuster?hl=en.