ANTLR 4 with BQL grammar?

[Otis]

Hi,

Would it be possible to use BQL grammar with ANTLR 4?

Over on https://theantlrguy.atlassian.net/wiki/pages/viewpage.action?pageId=1900596 Terrence Parr, ANTLR author, says:
"The biggest difference between ANTLR 3 and 4 is that ANTLR 4 takes any grammar you give it unless the grammar had indirect left recursion. "

Has anyone tried using ANTLR4 with BQL grammar?

Thanks,
Otis

--

Performance Monitoring * Log Analytics * Search Analytics

Solr & Elasticsearch Support * http://sematext.com/

[Otis]

Wow, not sure if Sensei devs saw this, but a person from ANTLR world jumped in and issues this PR:

https://github.com/senseidb/sensei/pull/23

Background:

https://groups.google.com/d/msg/antlr-discussion/KqANyZqXvTo/hSPndXqyGPAJ

Would be great for Sensei if this went in, no?

Otis

--

Performance Monitoring * Log Analytics * Search Analytics

Solr & Elasticsearch Support * http://sematext.com/

[John Wang]

This is great!

Thanks Otis!

Baoqiu, do you want to take a look and let's get this in as soon as possible.

Thanks

-John

--
You received this message because you are subscribed to the Google Groups "Sensei" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sensei-searc...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Yonghui Zhao]

Let's merge in the change, and fix the ut, and do some test.

[Yonghui Zhao]

I have pulled https://github.com/sharwell/sensei/tree/antlr4 to my local branch.

I will do some test, before I merge it to master

[bao...@gmail.com]

Looks to me the original patch author is still working on it. I will take a look at ANTLR 4 and learn about his change, and then work with Yonghui to get the patch into our main branch.

Thanks,
Baoqiu


Yonghui Zhao <zhaoy...@gmail.com>编写：

For more options, visit https://groups.google.com/d/optout.

[Yonghui Zhao]

I have fixed the test case.

Error message are from 2 sources now. 

1.  IllegalStateException from BQLCompilerAnalyzer
2.  ParseCancellationException from BQLParser

https://github.com/yozhao/sensei/commit/aeeaf538cb3c4e847bc3a754b7e7260888a86435

[Yonghui Zhao]

Sam fixed the test case.

Now antlr is upgrade to v4. The pull request is merged.

Thanks Otis.

[Baoqiu Cui]

Thanks to everyone for the great help!

Baoqiu