Caught 2015
Giraldo Allain
These ideally sized 5 oz. wild caught Keta salmon fillets feature our original recipe marinade and a unique pop-up timer that makes the perfect preparation goof-proof. See below for No Name Wild Caught Salmon Fillet recipes.
Salmon are kind of like onions. No, not because they make you cry. Hopefully salmon don't make you cry. They're similar because you can buy onions that are grown on a farm, but you can also find and harvest onions in the wild, too. Both onions, both very different things. The same goes for salmon. When you buy fish at the market, you will most likely see some labeled "farm-raised" and some labeled "wild" or "wild-caught." Sure, they're both salmon, but they're very different things. What is the difference, you ask? Great question. Here's what to expect from salmon, whether you go the farm-raised or wild-caught route:
In this function that handles a REST API call, any of the called functions to handle parts of the request might throw an error to signal that an error code should be sent as response. However, the function itself might also discover an error, at which point it should jump into the exception handling block.
Webstorm will underline the throw with the following message: 'throw' of exception caught locally. This inspection reports any instances of JavaScript throw statements whose exceptions are always caught by containing try statements. Using throw statements as a "goto" to change the local flow of control is likely to be confusing.
I could write a new function that does the isAllowed check and throws an exception if it doesn't succeed, but that seems to be sidestepping the issue, rather than fixing a design problem that Webstorm is supposedly reporting.
Contrary to James Thorpe's opinion, I slightly prefer the pattern of throwing. I don't see any compelling reason to treat local errors in the try block any differently from errors that bubble up from deeper in the call stack... just throw them. In my opinion, this is a better application of consistency.
In addition, handling the error has the drawback of making you remember to return early so that the try block doesn't continue to execute logic after the error is encountered. This can be quite easy to forget.
You're checking for something and throwing an exception if isAllowed fails, but you know what to do in that situation - call sendErrorCode. You should throw exceptions to external callers if you don't know how to handle the situation - ie in exceptional circumstances.
The first side is performance. If this is a bottleneck and it is potentially possible to use it with compilation or when transferring to new (not yet released) versions of nodejs, the presence of repetitions is not always a bad solution. It seems that the IDE hints precisely in this case and that such a design can lead to poor optimization in some cases.
@James Thorpe's answer looks good to me, but @matchish feels it violates DRY. I say that in general, it does not. DRY, which stands for Don't Repeat Yourself, is defined by the people who coined the phrase as "Every piece of knowledge must have a single, unambiguous, authoritative representation within a system". As applied to writing software code, it is about not repeating complex code.
Practically any code that is said to violate DRY is said to be "fixed" by extracting the repeated code into a function and then calling that function from the places it was previously repeated. Having multiple parts of your code call sendErrorCode is the solution to fixing a DRY problem. All of the knowledge of what to do with the error is in one definitive place, namely the sendErrorCode function.
The larger question is what is the likelihood of the error and is it appropriate to treat !isAllowed as an exception. Exceptions are meant to handle unusual or unpredictable situations. I would expect !isAllowed to be a normal occurrence that should be handled with logic specific to that situation, unlike, say, a sudden inability to query the database that has the answer to the isAllowed question.
@matchish's proposed solution changes the contract of doSomethingOnAllowedRequest from something that will never throw an exception to something that will routinely throw an exception, placing the burden of exception handling on all of its callers. This is likely to cause a violation of DRY by causing multiple callers to have repetitions of the same error handling code, so in the abstract I do not like it. In practice, it would depend on the overall situation, such as how many callers are there and do they, in fact, share the same response to errors.
Answer of James Thorpe has one disadvantage on my opinion. It's not DRY, in both cases when you call sendError you handle Exceptions. Let's imagine we have many lines of code with logic like this where Exception can be thrown. I think it can be better.
Following the suggestion by Uncle Bob in Clean Code stating that "a function is supposed to do one thing, do it well and do it only", I would say that if in your function you end up having an exception thrown and caught locally, most likely your function is not doing just one thing, making it hard to read and be modified.
"The reason why your try catch block is failing is because an ajax request is asynchronous. The try catch block will execute before the Ajax call and send the request itself, but the error is thrown when the result is returned, AT A LATER POINT IN TIME.
When the try catch block is executed, there is no error. When the error is thrown, there is no try catch. If you need try catch for ajax requests, always put ajax try catch blocks inside the success callback, NEVER outside of it."
Here, in the Indonesian island village of Benjina and the surrounding waters, hundreds of trapped men represent one of the most desperate links criss-crossing between companies and countries in the seafood industry. This intricate web of connections separates the fish we eat from the men who catch it, and obscures a brutal truth: Your seafood may come from slaves.
The men the AP interviewed on Benjina were mostly from Myanmar, also known as Burma, one of the poorest countries in the world. They were brought to Indonesia through Thailand and forced to fish. Their catch was then shipped back to Thailand, where it entered the global stream of commerce.
The tainted seafood mixes in with other fish at a number of sites in Thailand, including processing plants. U.S. Customs records show that several of those Thai factories ship to America. They also sell to Europe and Asia, but the AP traced shipments to the U.S., where trade records are public.
By this time, it is nearly impossible to tell where a specific fish caught by a slave ends up. However, entire supply chains are muddied, and money is trickling down the line to companies that benefit from slave labor.
The major corporations contacted would not speak on the record but issued statements that strongly condemned labor abuses. All said they were taking steps to prevent forced labor, such as working with human rights groups to hold subcontractors accountable.
Several independent seafood distributors who did comment described the costly and exhaustive steps taken to ensure their supplies are clean. They said the discovery of slaves underscores how hard it is to monitor what goes on halfway around the world.
Santa Monica Seafood, a large independent importer that sells to restaurants, markets and direct from its store, has been a leader in improving international fisheries, and sends buyers around the world to inspect vendors.
They said the captains on their fishing boats forced them to drink unclean water and work 20- to 22-hour shifts with no days off. Almost all said they were kicked, whipped with toxic stingray tails or otherwise beaten if they complained or tried to rest. They were paid little or nothing, as they hauled in heavy nets with squid, shrimp, snapper, grouper and other fish.
Roughly 3,500 people live in the town that straddles two small islands separated by a five-minute boat ride. Part of the Maluku chain, formerly known as the Spice Islands, the area is about 400 miles north of Australia, and hosts small kangaroos and rare birds of paradise with dazzling bright feathers.
Benjina is impossible to reach by boat for several months of the year, when monsoon rains churn the Arafura Sea. It is further cut off by a lack of Internet access. Before a cell tower was finally installed last month, villagers would climb nearby hills each evening in the hope of finding a signal strong enough to send a text. An old landing strip has not been used in years.
The Thai government also promises a new national registry of illegal migrant workers, including more than 100,000 flooding the seafood industry. However, policing has now become even harder because decades of illegal fishing have depleted stocks close to home, pushing the boats farther and deeper into foreign waters.
Indonesian officials are trying to enforce laws that ban cargo ships from picking up fish from boats at sea. This practice forces men to stay on the water for months or sometimes years at a time, essentially creating floating prisons.
Susi Pudjiastuti, the new Fisheries Minister, said she has heard of different fishing companies putting men in cells. She added that she believes the trawlers on Benjina may really have Thai owners, despite the Indonesian paperwork, reflecting a common practice of faking or duplicating licenses.
Agents have become more desperate and ruthless, recruiting children and the disabled, lying about wages and even drugging and kidnapping migrants, according to a former broker who spoke on condition of anonymity to avoid retribution.
Illegal workers are given false documents, because Thai boats cannot hire undocumented crew. One of the slaves in Benjina, Maung Soe, said he was given a fake seafarer book belonging to a Thai national, accepted in Indonesia as an informal travel permit. He rushed back to his boat to dig up a crinkled copy.
c80f0f1006