Proposal to give Thomas Walpole a commit-bit

388 views
Skip to first unread message

Titus Fortner

unread,
Jan 11, 2019, 1:55:32 PM1/11/19
to selenium-...@googlegroups.com
Thomas Walpole (@twalpole) has been the project lead for Capybara for
the past 5 years. As a developer of a major project that consumes
Selenium he has a lot of insight into how Selenium works and hands-on
experience with the Ruby bindings in particular. He's filed bugs for
w3c and driver issues and has been increasingly involved in assisting
users in the Selenium chat room.

He and I have been collaborating recently (i.e. stealing ideas from
each other for our respective Watir/Capybara projects), and I think
his perspective and skills would be valuable to the Selenium code
base.

Thanks,
Titus

p0deje

unread,
Jan 11, 2019, 7:52:03 PM1/11/19
to selenium-...@googlegroups.com
Nice!

+1
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAKSYPuiXQ1L57C823UG8%3DanuEDA_g0gYDKGkuS5VypvU1W6emA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Lucas Tierney

unread,
Jan 11, 2019, 10:16:29 PM1/11/19
to Selenium Developers
+1 from me too

Diego Fernando Molina

unread,
Jan 14, 2019, 8:51:06 AM1/14/19
to Selenium Developers
+1

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/a0066aec-18d5-4464-bc4a-b14cf84d636b%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.


--

Diego Fernando Molina

Alexei Barantsev

unread,
Jan 15, 2019, 7:07:39 AM1/15/19
to Selenium Developers
+1

David Burns

unread,
Jan 15, 2019, 8:34:24 AM1/15/19
to selenium-...@googlegroups.com
~1 Not had enough interactions with him but happy to go with the group here.

David

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/bcea3ae2-bfcf-4d9f-89ec-cb96a28b3e2e%40googlegroups.com.

Simon Stewart

unread,
Jan 16, 2019, 6:41:15 AM1/16/19
to selenium-developers
Hi everyone,

Welcome to the project, Thomas!

When Lucas got the commit bit, I wrote some of the guidelines we follow on the project. It's always helpful to have a reminder:

* Be excellent to each other
* We prefer to practice Trunk Based Development
* We prefer single logical changes over dozens of tiny commits (squash and rebase is our friend, merge commits are generally a no-no)
* Don't force push a branch you don't own
* That goes double for master
* It's cool to push to master if you think it'll be okay
* But if it's not, try and fix it.

Happy hacking, and, once again, welcome!

Simon

To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAPmg_cvdF-05jzda4az1x7R-zi7_8%3DWhO0jgEwwc6fCOL3zJXQ%40mail.gmail.com.

Veena Devi

unread,
Jan 25, 2019, 3:39:29 PM1/25/19
to selenium-...@googlegroups.com
1

Would like to be the part of this great team

Thomas Walpole

unread,
Jan 25, 2019, 3:39:30 PM1/25/19
to Selenium Developers
Hi everyone,

  Thanks for the invite - the guidelines all seem reasonable and hopefully I can provide value to the project. On a related note if anyone has any feedback on https://github.com/SeleniumHQ/selenium/pull/6843 I'd appreciate it.  Especially if anyone has ideas on a better way to solve the issue, or get around IE hanging on to open file handles even after it has finished uploading the files.

Thomas
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.

Simon Stewart

unread,
Jan 28, 2019, 7:56:31 AM1/28/19
to selenium-developers
I had a quick look. It looks great, but I've added a few review comments. That's a good catch. Thank you!

Simon

To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/a7dfbb4b-3a63-426a-b3a4-99bf1d2151bf%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages