Issue 5034 in selenium: "global name 'WindowsError' is not defined" in Linux

[sele...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Status-Untriaged

New issue 5034 by liyaz...@douban.com: "global name 'WindowsError' is not
defined" in Linux
http://code.google.com/p/selenium/issues/detail?id=5034

{{
Traceback (most recent call last):
File "/usr/lib64/python2.7/site-packages/webpage_capture_screen_server/app.py",
line 51, in restart_driver self.driver.quit()
File "/usr/lib64/python2.7/site-packages/selenium/webdriver/phantomjs/webdriver.py",
line 68, in quit
self.service.stop()

File "/usr/lib64/python2.7/site-packages/selenium/webdriver/phantomjs/service.py",
line 91, in stop
except WindowsError:
NameError: global name 'WindowsError' is not defined
}}

selenium version: 2.28.0

[sele...@googlecode.com]

Updates:
Labels: Lang-Python Browser-PhantomJS

Comment #1 on issue 5034 by barancev: "global name 'WindowsError' is not

defined" in Linux
http://code.google.com/p/selenium/issues/detail?id=5034

(No comment was entered for this change.)

[sele...@googlecode.com]

Comment #2 on issue 5034 by me.ssw...@gmail.com: "global

name 'WindowsError' is not defined" in Linux
http://code.google.com/p/selenium/issues/detail?id=5034

WindowsError is platform specific and have been obsoleted, I think take
OSError is better...

And here is the patch, please check.

ref:
http://mail.python.org/pipermail/python-checkins/2012-December/118282.html

Attachments:
oserror.patch 505 bytes

[sele...@googlecode.com]

Updates:
Status: Accepted
Owner: luke.semerau
Labels: -Status-Untriaged

Comment #3 on issue 5034 by luke.semerau: "global name 'WindowsError' is

not defined" in Linux
http://code.google.com/p/selenium/issues/detail?id=5034

Have you signed the cla?
http://goo.gl/qC50R

[sele...@googlecode.com]

Updates:
Status: Fixed

Comment #4 on issue 5034 by luke.semerau: "global name 'WindowsError' is

not defined" in Linux
http://code.google.com/p/selenium/issues/detail?id=5034

This issue was closed by revision 55a09d9ebd3f.