Issue 4024 in selenium: Updated Javadoc comments for both server and client tree in 2.22.0 revision 17049

4 views
Skip to first unread message

sele...@googlecode.com

unread,
Jun 4, 2012, 3:08:34 PM6/4/12
to selenium-develope...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Status-Untriaged

New issue 4024 by lvskip...@gmail.com: Updated Javadoc comments for both
server and client tree in 2.22.0 revision 17049
http://code.google.com/p/selenium/issues/detail?id=4024

I had to fix these warnings in Selenium-Java-Client by including
android-14.jar from selenium-2.22.0\trunk\third_party\java\android - so
maybe this should be kept in the lib directory in the release:

H:\NetBeansProjects\selenium-2.22.0\trunk\java\client\src\org\openqa\selenium\android\library\DefaultViewClient.java:25:
cannot
find symbol
symbol : class WebResourceResponse
location: package android.webkit
import android.webkit.WebResourceResponse;
H:\NetBeansProjects\selenium-2.22.0\trunk\java\client\src\org\openqa\selenium\android\library\DefaultViewClient.java:138:
cannot
find symbol
symbol : class WebResourceResponse
location: class org.openqa.selenium.android.library.DefaultViewClient
public WebResourceResponse shouldInterceptRequest(WebView view, String
url) {
H:\NetBeansProjects\selenium-2.22.0\trunk\java\client\src\org\openqa\selenium\android\library\EventSender.java:19:
cannot
find symbol
symbol : class InputDevice
location: package android.view
import android.view.InputDevice;

For Selenium-Server I fixed not only some mistakes in the Selenium Javadoc
comments, I also fixed some in the cybervillains code, which I hope we can
give back to them. There was one error I could not fix, because I simply
do not know what was intended by the author of this section of the code:

H:\NetBeansProjects\selenium-2.22.0\trunk\java\server\src\org\openqa\grid\internal\TestSlot.java:100:
warning
- Tag @link: can't find setCapabilityHelper(CapabilityMatcher) in
org.openqa.grid.internal.RemoteProxy

There are also what appear to be two spelling errors for that method:
testslot (should this be two words?) and histing (hosting?)


So this fixes all the Javadoc issues I see in 2.22.0, with the exception of
the one listed above for Selenium-Server.

I am glad to see that the ones I put in issue 2787 were useful and hope
these will be as well.


Attachments:
Selenium-Client.patch 6.5 KB
Selenium-Server.patch 8.0 KB

sele...@googlecode.com

unread,
Jun 5, 2012, 5:52:21 AM6/5/12
to selenium-develope...@googlegroups.com
Updates:
Labels: Component-Docs

Comment #1 on issue 4024 by barancev: Updated Javadoc comments for both
server and client tree in 2.22.0 revision 17049
http://code.google.com/p/selenium/issues/detail?id=4024

(No comment was entered for this change.)

sele...@googlecode.com

unread,
Jun 5, 2012, 12:59:10 PM6/5/12
to selenium-develope...@googlegroups.com

Comment #2 on issue 4024 by lvskip...@gmail.com: Updated Javadoc comments
for both server and client tree in 2.22.0 revision 17049
http://code.google.com/p/selenium/issues/detail?id=4024

I withdraw my comment about adding the android-14.jar file to the libs
directory so that Javadoc builds work properly. I found it is only stub
routines that cause your Selenium to throw exceptions all over the place:

https://groups.google.com/forum/?fromgroups&hl=en#!topic/selenium-users/Eem3bUiBbd4

sele...@googlecode.com

unread,
Jun 12, 2012, 9:46:00 AM6/12/12
to selenium-develope...@googlegroups.com
Updates:
Status: Duplicate
Mergedinto: 4057

Comment #3 on issue 4024 by barancev: Updated Javadoc comments for both
server and client tree in 2.22.0 revision 17049
http://code.google.com/p/selenium/issues/detail?id=4024

Reply all
Reply to author
Forward
0 new messages