[selenium] r15506 committed - DanielWagnerHall: Fix firefoxdriver references to bot.userAgent.isVers...

0 views
Skip to first unread message

sele...@googlecode.com

unread,
Jan 13, 2012, 12:28:34 PM1/13/12
to selenium-deve...@googlegroups.com
Revision: 15506
Author: dawagner
Date: Fri Jan 13 09:28:06 2012
Log: DanielWagnerHall: Fix firefoxdriver references to
bot.userAgent.isVersion which no longer exists
http://code.google.com/p/selenium/source/detail?r=15506

Modified:
/trunk/javascript/firefox-driver/extension/components/webLoadingListener.js
/trunk/javascript/firefox-driver/js/locators.js
/trunk/javascript/firefox-driver/js/modals.js

=======================================
---
/trunk/javascript/firefox-driver/extension/components/webLoadingListener.js
Tue Jan 10 09:16:06 2012
+++
/trunk/javascript/firefox-driver/extension/components/webLoadingListener.js
Fri Jan 13 09:28:06 2012
@@ -62,7 +62,7 @@
// On versions of firefox prior to 4 removing a listener may cause
// subsequent listeners to be skipped. Favouring a memory leak over
// not working properly.
- if (bot.userAgent.isVersion('4')) {
+ if (bot.userAgent.isProductVersion('4')) {
WebLoadingListener.removeListener(this.browser, this);
}
this.onComplete(webProgress);
@@ -105,7 +105,7 @@
// On versions of firefox prior to 4 removing a listener may cause
// subsequent listeners to be skipped. Favouring a memory leak over
// not working properly.
- if (bot.userAgent.isVersion('4')) {
+ if (bot.userAgent.isProductVersion('4')) {
WebLoadingListener.removeListener(this.browser, listener);
}
this.onComplete(webProgress || this.browserProgress);
=======================================
--- /trunk/javascript/firefox-driver/js/locators.js Tue Jan 10 09:16:06 2012
+++ /trunk/javascript/firefox-driver/js/locators.js Fri Jan 13 09:28:06 2012
@@ -25,7 +25,7 @@
goog.require('goog.dom');


-if (!bot.userAgent.isVersion('3.5')) {
+if (!bot.userAgent.isEngineVersion('3.5')) {
fxdriver.Logger.dumpn("Replacing CSS lookup mechanism with Sizzle");
var cssSelectorFunction = (function() {
var sizzle = [
=======================================
--- /trunk/javascript/firefox-driver/js/modals.js Tue Jan 10 09:16:06 2012
+++ /trunk/javascript/firefox-driver/js/modals.js Fri Jan 13 09:28:06 2012
@@ -71,7 +71,7 @@

try {
var isVisible = false;
- if (bot.userAgent.isVersion(8)) {
+ if (bot.userAgent.isEngineVersion(8)) {
isVisible = textbox.clientHeight != 0;
} else {
isVisible = textbox.selectionStart > -1;

Reply all
Reply to author
Forward
0 new messages