Re: Added a password strength calculator class and unit tests. Added label displaying master password... (issue4662062)

8 views

Skip to first unread message

unread,

Jul 25, 2011, 11:52:49 PM7/25/11

to ste...@chromium.org, rog...@chromium.org, secrets-f...@googlegroups.com, re...@codereview.appspotmail.com

lgtm

Thanks for contributing Steve. I'll patch this in soon. I'll implement
the suggestion i mention below and see that the code looks like.

http://codereview.appspot.com/4662062/diff/5001/src/net/tawacentral/roger/secrets/LoginActivity.java#newcode388
src/net/tawacentral/roger/secrets/LoginActivity.java:388: String text =
getString(R.string.password_strength_caption) + " ";
do you need the trailing space?

http://codereview.appspot.com/4662062/diff/5001/src/net/tawacentral/roger/secrets/LoginActivity.java#newcode421
src/net/tawacentral/roger/secrets/LoginActivity.java:421: }
you don't like the idea of putting the text and colour as properties of
the str instance?