Re: Added a password strength calculator class and unit tests. Added label displaying master password... (issue4662062)

53 views

Skip to first unread message

rog...@google.com

unread,

Jun 28, 2011, 10:56:14 PM6/28/11

to ste...@chromium.org, rog...@chromium.org, secrets-f...@googlegroups.com, re...@codereview.appspotmail.com

http://codereview.appspot.com/4662062/diff/1/res/values/strings.xml
File res/values/strings.xml (right):

http://codereview.appspot.com/4662062/diff/1/res/values/strings.xml#newcode142
res/values/strings.xml:142: <string
name="password_strength_caption">Password Strength:</string>
Make this a format string, like:

Password strength: {0}

then use MessageFormat to build the string. This makes the message i18n
ready.

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/LoginActivity.java
File src/net/tawacentral/roger/secrets/LoginActivity.java (right):

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/LoginActivity.java#newcode153
src/net/tawacentral/roger/secrets/LoginActivity.java:153:
strength.setVisibility(TextView.INVISIBLE);
should this INVISIBLE or GONE?

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/LoginActivity.java#newcode300
src/net/tawacentral/roger/secrets/LoginActivity.java:300:
strength.setVisibility(TextView.INVISIBLE);
GONE ?

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/LoginActivity.java#newcode390
src/net/tawacentral/roger/secrets/LoginActivity.java:390: String text =
getString(R.string.password_strength_caption) + " ";
use MessageFormat here.

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrength.java
File src/net/tawacentral/roger/secrets/PasswordStrength.java (right):

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrength.java#newcode54
src/net/tawacentral/roger/secrets/PasswordStrength.java:54: }
do we need this level of granularity at the low end? is it important to
know the password is very-weak vs weak? maybe it would be better to
reduce granularity at the low end and even increase at the high end.
give people an incentive to pick strong passwords :-) so maybe
something like:

weak, medium, strong, very strong, crazy/stupid/geek strong

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrength.java#newcode56
src/net/tawacentral/roger/secrets/PasswordStrength.java:56: /**
Calculate the new strength of the password based on a new change in the
newline before Calculate...

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrength.java#newcode72
src/net/tawacentral/roger/secrets/PasswordStrength.java:72: /** Helper
used to append to the current password strength score based on
newline before Helper...

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrength.java#newcode90
src/net/tawacentral/roger/secrets/PasswordStrength.java:90: for (int ix
= 0; ix < sequence.length(); ix++) {
ix ?

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrengthTest.java
File src/net/tawacentral/roger/secrets/PasswordStrengthTest.java
(right):

http://codereview.appspot.com/4662062/diff/1/src/net/tawacentral/roger/secrets/PasswordStrengthTest.java#newcode66
src/net/tawacentral/roger/secrets/PasswordStrengthTest.java:66:
test(PasswordStrength.Strength.VERY_STRONG, "Space separated words are
good!1");
line too long.