[COMMIT seastar master] reactor_config: update stale doc comments

2 views
Skip to first unread message

Commit Bot

<bot@cloudius-systems.com>
unread,
Oct 3, 2022, 1:48:10 PM10/3/22
to seastar-dev@googlegroups.com, Michał Chojnowski
From: Michał Chojnowski <michal.c...@scylladb.com>
Committer: Pavel Emelyanov <xe...@scylladb.com>
Branch: master

reactor_config: update stale doc comments

The default value of blocked-reactor-notify-ms was reduced
from 200 ms to 25 ms in 0464eae94307.
The default value of task-quota-ms was reduced
from 500 ms to 0.5 ms in cf0b43c52de.
But the relevant doc comments weren't adjusted accordingly. Fix that.

Closes #1227

---
diff --git a/include/seastar/core/reactor_config.hh b/include/seastar/core/reactor_config.hh
--- a/include/seastar/core/reactor_config.hh
+++ b/include/seastar/core/reactor_config.hh
@@ -59,7 +59,7 @@ struct reactor_options : public program_options::option_group {
program_options::value<bool> poll_aio;
/// \brief Max time (ms) between polls.
///
- /// Default: 500.
+ /// Default: 0.5.
program_options::value<double> task_quota_ms;
/// \brief Max time (ms) IO operations must take.
///
@@ -74,7 +74,7 @@ struct reactor_options : public program_options::option_group {
/// \brief Threshold in milliseconds over which the reactor is considered
/// blocked if no progress is made.
///
- /// Default: 200.
+ /// Default: 25.
program_options::value<unsigned> blocked_reactor_notify_ms;
/// \brief Maximum number of backtraces reported by stall detector per minute.
///
Reply all
Reply to author
Forward
0 new messages