[COMMIT seastar master] core/resource: move a value only for sanity check into `if` clause

0 views
Skip to first unread message

Commit Bot

<bot@cloudius-systems.com>
unread,
Feb 1, 2023, 1:26:20 PM2/1/23
to seastar-dev@googlegroups.com, Kefu Chai
From: Kefu Chai <kefu...@scylladb.com>
Committer: Kefu Chai <tcha...@gmail.com>
Branch: master

core/resource: move a value only for sanity check into `if` clause

minimize its lexical scope helps to improve the readability.

Signed-off-by: Kefu Chai <kefu...@scylladb.com>

---
diff --git a/src/core/resource.cc b/src/core/resource.cc
--- a/src/core/resource.cc
+++ b/src/core/resource.cc
@@ -509,9 +509,9 @@ resources allocate(configuration& c) {
#endif
size_t mem = calculate_memory(c, std::min(available_memory,
cgroup::memory_limit()));
- unsigned available_procs = hwloc_get_nbobjs_by_type(topology, HWLOC_OBJ_PU);
unsigned procs = c.cpus;
- if (procs > available_procs) {
+ if (unsigned available_procs = hwloc_get_nbobjs_by_type(topology, HWLOC_OBJ_PU);
+ procs > available_procs) {
throw std::runtime_error(format("insufficient processing units: needed {} available {}", procs, available_procs));
}
if (procs == 0) {
Reply all
Reply to author
Forward
0 new messages