Another seaglass mod / bugfixes

63 views
Skip to first unread message

Rossi

unread,
Jan 3, 2011, 5:58:54 PM1/3/11
to sea-glass-l...@googlegroups.com
Hello together,
A happy new year to all of you.
I was fed up with eating christmas cookies all the time, so I opened Eclipse
and did some more hacking on seaglass. I started with some minor changes of
the look of some components but then I could not stop. Now a few days later I
think it is time to give something of this back to the community because a lot
of changes have already acummulated.

What I did is:
- Removing all dependencies to Nimbus so that it is a clean Synth based L&F
now (This fixes a lot of bugs when switching from or to Nimbus and will
make more reliable when using JDK 1.7)
- Adding all icons for the OptionPane and the JFileChooser dialogs
- Improving the look of JProgressBar, JSlider, JSeparator, Menus, ...
- Adding a main frame icon / system menu
- Adding a new system property "SeaGlass.JTextArea.drawLineSeparator" to draw
text lines in JTextAreas.
- Added a background painter for the desktop pane
- many other minor improvements.

I did uncountable bug fixes: To name some:
+ Most bugs reported in the issue tracker are fixed now I believe
+ A lot of margins adjusted
+ A lot of fixes for size variants
+ A lot of fixes for colors/painters that where inherited from Nimbus and are
now explicitly defined in Seaglass
+ many many others I already forgot

Known issues:
- RTL support is incomplete yet. (Spinner, Progressbar and Slider are not
correct, the rest looks already OK)
- the unified toolbar styling is not finished yet (Toolbar Buttons and
Components have a blue focus that has no good contrast) But normal Menus and
Toolbar looks OK now.
- The SeaGlass.JRootPane.MenuInTitle is broken because I added the Main Frame
Icon / System Menu.
- Combobox size variants do not work
- Some other minor issues

With all this changes Seaglass works already quite well for me (90%
completion). I may not be perfect for others, depending on the features that
you use or if you do not like the way I restyled some components.

This is just a rough summary of the changes that I remember. If you are
interested at this I have uploaded an Eclipse workspace and a binary jar.

Eclipse Workspace can be found under:
http://www.rosstauscher.de/seaglass_rossi_mod2.zip

The compiled L&F binary can be found under:
http://www.rosstauscher.de/seaglasslookandfeel-rossi-mod_20110103.jar

I will continue some more development on this to fix the remaining issues that
I am aware of and then do a another upload.

If you test this and find bugs or have some other comments I'm interested in
hearing them.

If you want to integrate some or all of this into the offical seaglass code base
you are free to do so. I contribute everything under whatever license you
need. But I think merging parts of this will be a lot of work.

Have fun,
- Rossi

Eugene Kononov

unread,
Jan 3, 2011, 7:49:55 PM1/3/11
to sea-glass-l...@googlegroups.com
Thanks Rossi, I gave it a quick test. It looks good, but there are some issues which were not present in your previous version.

1. JPasswordField shows symbols other than asterisks.
2. JSlider doesn't repaint correctly when sliding
3. JSpinner height is too small, not enough to display text.
4. TitledBorder loses the title.

I attached the images to demonstrate all 4 issues.
JPasswordFieldIssue.png
JSliderIssue.png
JSpinnerIssue.png
TtitledBorderIssue.png

Ken Orr

unread,
Jan 3, 2011, 10:29:54 PM1/3/11
to sea-glass-l...@googlegroups.com
I must say, from an aesthetic standpoint, Sea Glass is really shaping up! Nice to see that others are contributing back to the project as well. I'm sure Kathryn will appreciate the help.

-Ken

Bernd Rosstauscher

unread,
Jan 4, 2011, 2:56:21 AM1/4/11
to sea-glass-l...@googlegroups.com

Hello Eugene,

Thanks for the feedback.
What plattform are you testing under?

> 1. JPasswordField shows symbols other than asterisks.

This is intentional. I tested different echo characters for the
password field. I do not like the * and changed it many different and stayed with 'o' but this is no final decision. I just forgot to change it back.
You can change this by yourself with
UIManager.getDefaults().put("PasswordField.echoChar", '*');

> 2. JSlider doesn't repaint correctly when sliding

This does not occure for me. (Developing under Linux)
The filled blue track area seems to to be 1 pixel to long.
I will retest this and see if I can fix this.

> 3. JSpinner height is too small, not enough to display text.

Hmm did not notice that too. In Laffy this looks correct. Maybe an
contentMargin issue. What layout do you use in your example?

> 4. TitledBorder loses the title.

This is a regression because I removed all dependencies to Nimubus.
Nimbus did the Titled Border styling. I will add some code to style
this in seaglass similar.

Thanks for the valueable input.
This is exactly what is needed. Feedback from real world scenarios because
Laffy does not cover all layout situations.


Have fun,
- Rossi

--
Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief!
Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

Eugene Kononov

unread,
Jan 4, 2011, 8:21:41 AM1/4/11
to sea-glass-l...@googlegroups.com
Rossi,

My app runs under Windows Vista, JDK 1.6. 
I noticed another issue: the highlighted row in JTable renders with the vertical white lines which were not there before. See attached pic.
TableRenderingIssue.png

Kathryn Huxtable

unread,
Jan 4, 2011, 11:39:52 AM1/4/11
to sea-glass-l...@googlegroups.com
Kathryn is getting a new full-time job. I may not have much time for Sea Glass. -K
Reply all
Reply to author
Forward
0 new messages