Re: [SDRuby] Question about code review and refactoring?

[Ian Young]

Good question, Michael. I'm curious to hear any other responses you get. I was recently talking to a friend in Chicago who's working at his first serious Ruby gig and suggested he try to get code reviews to help him improve (unfortunately, the rest of his company is not Rubyists).

If you're using Ruby for your day job, I'd suggest talking to your boss about hiring a contractor to do a few hours of code review every week. Point out that it's both an investment in your code quality, *and* it's employee development. I'd imagine you could find some freelancers in this group with lots of Ruby experience who would be willing to take a gig like that.

On Sat, May 11, 2013 at 12:28 PM, Michael Cordell <michael...@gmail.com> wrote:

Hello SD Rubyists,

I'm a new member to the group and attended my first meeting in April. I am also fairly new to Ruby and am trying to become better with it and programming in general. I wanted to ask this question at the May meeting, but it was cancelled, so here it goes:

Can anyone recommend resources for code review/refactoring of Ruby code? I've produced some stuff in Ruby and I know that Ruby has its own syntactical idioms. I would like to make my work better fit there idioms and in general be more Ruby-esque. Moreover, I think I would benefit from some general tips about making my code better. Many of the resources I turned up with Google seem to be defunct.

Thanks for the help,

Michael Cordell

--
--
SD Ruby mailing list
sdr...@googlegroups.com
http://groups.google.com/group/sdruby
---
You received this message because you are subscribed to the Google Groups "SD Ruby" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sdruby+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Cynthia Kiser]

Quoting Michael Cordell <michael...@gmail.com>:
> Can anyone recommend resources for code review/refactoring of Ruby code?
> I've produced some stuff in Ruby and I know that Ruby has its own
> syntactical idioms. I would like to make my work better fit there idioms
> and in general be more Ruby-esque. Moreover, I think I would benefit from
> some general tips about making my code better.

First I would suggest books: "Eloquent Ruby" will show you how to make
your code more Ruby-esque. "Practical Object Oriented Design in Ruby"
is a mind expanding book useful for any OO language - and especially
good on teaching you what to test so that your TDD is efficient and
effective.

For an outside critique of your code, finding someone in the local
Ruby community would probably be the most return for the time and
money. But I have heard good things about Code Climate - so you might
want to give them a try after you have gotten some in person pointers.
https://codeclimate.com/

--
Cynthia N. Kiser
c...@ugcs.caltech.edu

"Ever tried. Ever failed. No matter. Try again. Fail again. Fail better"
Worstward Ho
by Samuel Beckett

[Tony Doan]

You could try the Rubocop gem. It automates checking your code against the Ruby style guide. 

https://github.com/bbatsov/rubocop

YMMV

Tony

[Adam Grant]

I almost flipped my lid when I found out about this site!  It's something I want to do in my off time: http://codereview.stackexchange.com/

On May 12, 2013 2:57 PM, "Michael Cordell" <michael...@gmail.com> wrote:

Hello SD Rubyists,

I'm a new member to the group and attended my first meeting in April. I am also fairly new to Ruby and am trying to become better with it and programming in general. I wanted to ask this question at the May meeting, but it was cancelled, so here it goes:

Can anyone recommend resources for code review/refactoring of Ruby code? I've produced some stuff in Ruby and I know that Ruby has its own syntactical idioms. I would like to make my work better fit there idioms and in general be more Ruby-esque. Moreover, I think I would benefit from some general tips about making my code better. Many of the resources I turned up with Google seem to be defunct.

Thanks for the help,

Michael Cordell

[Michael Cordell]

Thanks for the suggestions everybody. I ordered Eloquent Ruby, I have read other books by that author and have liked his style. Also, I posted to codereview on stack exchange, I think it was exactly what I was looking for. I'll keep the other tools in mind as well.

Thanks again,

Michael